Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HG proc/core: fix couple of type changes that could have broken ABI #749

Merged
merged 1 commit into from
Aug 1, 2024
Merged

HG proc/core: fix couple of type changes that could have broken ABI #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mercury_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,7 +1083,7 @@ struct hg_core_addr {
#ifdef NA_HAS_SM
na_addr_t *na_sm_addr; /* NA SM address */
#endif
bool is_self; /* Self address */
uint8_t is_self; /* Self address */
};

/* HG core RPC registration info */
Expand All @@ -1092,7 +1092,7 @@ struct hg_core_rpc_info {
void *data; /* User data */
void (*free_callback)(void *); /* User data free callback */
hg_id_t id; /* RPC ID */
bool no_response; /* RPC response not expected */
uint8_t no_response; /* RPC response not expected */
};

/* HG core handle */
Expand Down Expand Up @@ -1255,7 +1255,7 @@ HG_Core_addr_get_na_sm(hg_core_addr_t addr)
static HG_INLINE bool
HG_Core_addr_is_self(hg_core_addr_t addr)
{
return addr->is_self;
return (bool) addr->is_self;
}

/*---------------------------------------------------------------------------*/
Expand Down
4 changes: 2 additions & 2 deletions src/mercury_proc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ struct hg_proc_buf {
void *buf_ptr; /* Pointer to current position */
hg_size_t size; /* Total buffer size */
hg_size_t size_left; /* Available size for user */
bool is_mine;
uint8_t is_mine;
#ifdef HG_HAS_XDR
XDR xdr;
#endif
Expand All @@ -608,7 +608,6 @@ struct hg_proc {
struct hg_proc_buf proc_buf;
struct hg_proc_buf extra_buf;
hg_class_t *hg_class; /* HG class */
hg_handle_t handle; /* HG handle */
struct hg_proc_buf *current_buf;
#ifdef HG_HAS_CHECKSUMS
struct mchecksum_object *checksum; /* Checksum */
Expand All @@ -617,6 +616,7 @@ struct hg_proc {
#endif
hg_proc_op_t op;
uint8_t flags;
hg_handle_t handle; /* HG handle */
};

/*---------------------------------------------------------------------------*/
Expand Down
Loading