-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor docs CSS dependencies #5350
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5350 +/- ##
============================================
+ Coverage 43.37% 79.22% +35.85%
============================================
Files 23 175 +152
Lines 5130 14531 +9401
Branches 23 868 +845
============================================
+ Hits 2225 11512 +9287
+ Misses 2904 2816 -88
- Partials 1 203 +202
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Btw, @maxstanley, I'm going to push to your branch and update this PR to fix the merge conflicts in the pnpm-lock.yaml
file and move the CSS dependencies from devDependencies
to dependencies
.
@maxstanley, Thank you for the contribution! |
📑 Summary
Remove dependencies on external sites for CSS on the docs pages.
📏 Design Decisions
package.json