Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor docs CSS dependencies #5350

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

maxstanley
Copy link
Contributor

📑 Summary

Remove dependencies on external sites for CSS on the docs pages.

📏 Design Decisions

  • Prefer centralised dependency management with package.json
  • Use vendored dependencies for simplified mirroring and deployment

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit fe905ce
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65e72ad457272a0009a543ea
😎 Deploy Preview https://deploy-preview-5350--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (b324574) to head (fe905ce).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5350       +/-   ##
============================================
+ Coverage    43.37%   79.22%   +35.85%     
============================================
  Files           23      175      +152     
  Lines         5130    14531     +9401     
  Branches        23      868      +845     
============================================
+ Hits          2225    11512     +9287     
+ Misses        2904     2816       -88     
- Partials         1      203      +202     
Flag Coverage Δ
e2e 84.79% <ø> (?)
unit 43.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 170 files with indirect coverage changes

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Btw, @maxstanley, I'm going to push to your branch and update this PR to fix the merge conflicts in the pnpm-lock.yaml file and move the CSS dependencies from devDependencies to dependencies.

packages/mermaid/src/docs/package.json Outdated Show resolved Hide resolved
@aloisklink aloisklink enabled auto-merge March 5, 2024 14:24
@aloisklink aloisklink added this pull request to the merge queue Mar 5, 2024
Merged via the queue into mermaid-js:develop with commit 972ecba Mar 5, 2024
20 checks passed
Copy link

mermaid-bot bot commented Mar 5, 2024

@maxstanley, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants