Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2853 today #5703

Closed
wants to merge 10 commits into from
Closed

Feature/2853 today #5703

wants to merge 10 commits into from

Conversation

bprb
Copy link

@bprb bprb commented Aug 9, 2024

📑 Summary

Add 'today' support in Gantt charts as per request 2853.

Resolves #2853

📏 Design Decisions

When the today keyword is present, its value overrides the default new Date() which is always "now". The value can be either a date in the Gantt's date format, or a duration.

📋 Tasks

Make sure you

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 72192fe
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66bf9ce354ece00008350007
😎 Deploy Preview https://deploy-preview-5703--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Type: Enhancement New feature or request label Aug 9, 2024
Copy link

argos-ci bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 47 changed, 2 added Aug 16, 2024, 6:50 PM

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 5.24%. Comparing base (c5eb07c) to head (72192fe).

Files Patch % Lines
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% 18 Missing ⚠️
packages/mermaid/src/diagrams/gantt/ganttDb.js 66.66% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5703      +/-   ##
==========================================
+ Coverage     5.22%   5.24%   +0.01%     
==========================================
  Files          322     322              
  Lines        46201   46230      +29     
  Branches       561     561              
==========================================
+ Hits          2415    2423       +8     
- Misses       43786   43807      +21     
Flag Coverage Δ
unit 5.24% <26.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/gantt/ganttDb.js 77.32% <66.66%> (-0.16%) ⬇️
...ckages/mermaid/src/diagrams/gantt/ganttRenderer.js 0.00% <0.00%> (ø)

@bprb bprb closed this Aug 16, 2024
@bprb bprb deleted the feature/2853_today branch August 16, 2024 18:41
@expatiating
Copy link

If you are looking for a solution... #2853 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new param today to specify the "data date"
2 participants