Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow share/cmake/ as cmake_prefix_path
This is to allow passing the path share/cmake/ as cmake_prefix_path. This is a case supported by cmake and is relied on by PyTorch. The cmake prefix of PyTorch can be found by running: python -c 'import torch.utils; print(torch.utils.cmake_prefix_path)' you will see something like below from the above command: /home/gaoxiang/.virtualenvs/nvfuser/lib/python3.11/site-packages/torch/share/cmake Inspecting this directory: ❯ tree /home/gaoxiang/.virtualenvs/nvfuser/lib/python3.11/site-packages/torch/share/cmake /home/gaoxiang/.virtualenvs/nvfuser/lib/python3.11/site-packages/torch/share/cmake ├── ATen │ └── ATenConfig.cmake ├── Caffe2 │ ├── Caffe2Config.cmake │ ├── Caffe2Targets.cmake │ ├── Caffe2Targets-release.cmake │ ├── FindCUDAToolkit.cmake │ ├── FindCUSPARSELT.cmake │ ├── Modules_CUDA_fix │ │ ├── FindCUDA.cmake │ │ ├── FindCUDNN.cmake │ │ └── upstream │ │ ├── CMakeInitializeConfigs.cmake │ │ ├── FindCUDA │ │ │ ├── make2cmake.cmake │ │ │ ├── parse_cubin.cmake │ │ │ ├── run_nvcc.cmake │ │ │ └── select_compute_arch.cmake │ │ ├── FindCUDA.cmake │ │ ├── FindPackageHandleStandardArgs.cmake │ │ └── FindPackageMessage.cmake │ └── public │ ├── cuda.cmake │ ├── gflags.cmake │ ├── glog.cmake │ ├── LoadHIP.cmake │ ├── mkl.cmake │ ├── mkldnn.cmake │ ├── protobuf.cmake │ └── utils.cmake ├── Tensorpipe │ ├── TensorpipeTargets.cmake │ └── TensorpipeTargets-release.cmake └── Torch ├── TorchConfig.cmake └── TorchConfigVersion.cmake 9 directories, 28 files However, meson currently filters this directory out by `_preliminary_find_check`. As a result, doing torch_dep = dependency('Torch') will fail, even if you set `cmake_prefix_path` with the value returned by PyTorch. Possibly related issues: https://stackoverflow.com/questions/68884434/libtorch-c-meson-dependency #9740 https://discuss.pytorch.org/t/libtorch-meson-build/139648
- Loading branch information