use typed_kwargs for vs_module_defs #12051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-schwartz
requested changes
Jul 31, 2023
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
3 times, most recently
from
5b6c5c3
to
3b13d10
Compare
64 tasks
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
from
3b13d10
to
2d5db86
Compare
|
Rebased on @eli-schwartz's work, tests added, docs added. Should be ready for review now |
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
from
2d5db86
to
86af405
Compare
tristan957
approved these changes
Jul 31, 2023
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
2 times, most recently
from
cee3f99
to
c895eb2
Compare
tristan957
reviewed
Jul 31, 2023
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
from
c895eb2
to
6a284fc
Compare
eli-schwartz
reviewed
Aug 7, 2023
Comment on lines
+5
to
+7
| defs = custom_target('generate_module_defs', ...) | ||
| shared_library('lib1', vs_module_defs : defs[0]) | ||
| shared_library('lib2', vs_module_defs : defs[2]) |
There was a problem hiding this comment.
Are there any actual use cases for this by the way? Because it was only ever discovered by a fuzzer.
There was a problem hiding this comment.
Apart from that it's strange to take CustomTarget but not CustomTargetIndex, it's likely niche that there's a real reason for it. The most realistic one I can think of is that you're generating code and the vs_module_defs together from a representative source of some kind, but you want to use a module defs file instead of the pre-processor:
ct = custom_target(
'from_xml',
input : 'functions.xml',
output : ['functions.hpp', 'functions.cpp', 'functions.def'],
command : ['xml-to-code', '@INPUT@', '@OUTPUT@'],
)
both_library(
'generated',
ct[0], ct[1],
vs_module_defs : ct[2],
)
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
from
6a284fc
to
17276d9
Compare
tristan957
approved these changes
Aug 14, 2023
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
from
17276d9
to
5a5fb9f
Compare
tristan957
reviewed
Sep 26, 2023
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
from
5a5fb9f
to
27fe7b3
Compare
tristan957
reviewed
Sep 26, 2023
tristan957
reviewed
Sep 26, 2023
There was a problem hiding this comment.
This looks good to me. @eli-schwartz did you have anything else to add?
Because `CustomTargetIndex`es don't have a `subdir` property, but they do implement the `get_subdir()` method
dcbaker
force-pushed
the
submit/vs-module-defs-typed
branch
from
27fe7b3
to
e9ca4b4
Compare
tristan957
approved these changes
Sep 27, 2023
eli-schwartz
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tristan957 had mentioned this was needed for Executables as well, but I haven't written a test case or doc changes for that yet.