-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo: Add support for target specific dependencies #13780
base: master
Are you sure you want to change the base?
Conversation
3a794cd
to
1fe38fb
Compare
763172c
to
a7f206c
Compare
CI passed, any objection? |
First commit message has a typo: "causer" -> "caused". I can't spot any obvious problems with the change but I would like to defer to @dcbaker on this as I don't know this subsystem very well. |
The first patch seems fine. The second means we can't reuse the same Meson generated between a host and build machine configuration, since now we've hard coded all of the machine info, nor could this parser be used in a generic I'm in general concerned about hardcoding machine information into the cargo Interpreter, now that it's a a class and we store a single instance in Environment, although there isn't too much in this that looks difficult to refactor into a cross compatible soluton, apart from the thing above. So, you have my RB for patches 1 and 3, but I'm absolutely not convinced by 2 |
@dcbaker cfg cannot be done in meson.build because it enables features which are global. By the point you interpret the generated meson.build it's too late. I think the |
Add cfg token to be able to parse the top level cfg() function. Fix parser which was creating a new iterator when recursing which caused the caller function's iterator to not have advanced when recursing function returns.
We'll need to evaluate those expressions before generating the AST. Instead take a config key-value dictionary and evaluate the expression to return a boolean.
a7f206c
to
b483c4b
Compare
fixed. |
No description provided.