Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix external_project failing due to the drive letter in the path on Windows #13916

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix external_project failing due to the drive letter in the path on Windows #13916

wants to merge 5 commits into from
+38 −8

Commits on Nov 23, 2024

  1. fix configure script executed with external_project failing on Windows 

    On Cygwin, MSYS2 and GitBash, the configure command should be
converted to unix style path by cygpath command,
because the colon in the drive letter breaks many configure scripts.
    @na-trium-144
    na-trium-144 committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    5377b63 View commit details
    Browse the repository at this point in the history

  2. add 'windows' and '!windows' as platform value in test configuration 

    It is needed to run test case common/230 on windows.
    @na-trium-144
    na-trium-144 committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    b5963fc View commit details
    Browse the repository at this point in the history

  3. enable test case common/230 on windows

    @na-trium-144
    na-trium-144 committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e412020 View commit details
    Browse the repository at this point in the history

  4. add verbose:true in test case common/230

    @na-trium-144
    na-trium-144 committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    51fac7c View commit details
    Browse the repository at this point in the history

  5. fix relpath computation in external_project prefix 

    This computation of prefix and rel_prefix was re-written in mesonbuild#13886
but it introduced another bug where the leading slash was missing.
In addition drive root should have trailing slash,
or it would use different path as base of relpath in some cases.
    @na-trium-144
    na-trium-144 committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    e5eeb77 View commit details
    Browse the repository at this point in the history