Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kommander-cert-federation): bump kubefed cli version to v0.10.4 #1491

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore(kommander-cert-federation): bump kubefed cli version to v0.10.4 #1491

merged 1 commit into from
Feb 27, 2024

Conversation

mhrabovcin
Copy link
Contributor

What type of PR is this?

Chore

What this PR does/ why we need it:

Bumps kubefed container image to latest built by d2iq

Which issue(s) this PR fixes:

https://d2iq.atlassian.net/browse/D2IQ-100008

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@mhrabovcin mhrabovcin requested review from a team as code owners February 27, 2024 15:55
@mhrabovcin mhrabovcin self-assigned this Feb 27, 2024
@mhrabovcin mhrabovcin added ready ready ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Feb 27, 2024
msdolbey
msdolbey approved these changes Feb 27, 2024
View reviewed changes
Copy link

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Looks good to me - I don't see any breaking changes from kubefed 0.9 -> 0.10 that would affect us
nice

@mhrabovcin mhrabovcin merged commit 95079c4 into master Feb 27, 2024
4 checks passed
@mhrabovcin mhrabovcin deleted the mh/kcf/udpate-kubefed-cli branch February 27, 2024 16:05
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
chore(kommander-cert-federation): bump kubefed cli version to v0.10.4 (…
054985c 
…#1491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdolbey msdolbey msdolbey approved these changes

@mikolajb mikolajb Awaiting requested review from mikolajb

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

@gracedo gracedo Awaiting requested review from gracedo

Assignees

@mhrabovcin mhrabovcin

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhrabovcin @msdolbey