Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kps): Bump to 56.13.1, clean up manifests #1492

Merged
merged 11 commits into from
Feb 28, 2024
Merged

feat(kps): Bump to 56.13.1, clean up manifests #1492

merged 11 commits into from
Feb 28, 2024

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Feb 28, 2024

What type of PR is this?

feat

What this PR does/ why we need it:

  • Bump to latest upstream
  • Clean up some unused manifests
  • Remove rbac ingress roles, and move them to be defined in k-apps. We really need to decrease the size of this chart in order for it to be deployable, which is the main motivation behind this removal.

Which issue(s) this PR fixes:

https://d2iq.atlassian.net/browse/D2IQ-99891

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@gracedo gracedo added ready ready ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Feb 28, 2024
@gracedo gracedo self-assigned this Feb 28, 2024
@gracedo gracedo marked this pull request as ready for review February 28, 2024 03:00
@gracedo gracedo requested review from a team as code owners February 28, 2024 03:00
@gracedo gracedo enabled auto-merge (squash) February 28, 2024 03:00
msdolbey
msdolbey approved these changes Feb 28, 2024
View reviewed changes
Copy link

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
this is a lot

@gracedo gracedo merged commit 616da67 into master Feb 28, 2024
4 checks passed
@gracedo gracedo deleted the gracedo/kps56131 branch February 28, 2024 03:16
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
feat(kps): Bump to 56.13.1, clean up manifests (#1492) * feat(kps): B…
9d16576 
…ump to 56.13.1 * feat(kps): Remove rbac clusterroles from chart * fix(kps): Remove unused helper snippet * chore: copy upstream chart version: 56.13.1 * chore: apply patch_3_mesosphere_hooks.sh * chore: apply patch_5_mesosphere_rules.sh * chore: apply patch_6_mesosphere_values.sh * chore: apply patch_7_patch_grafana_dashboards.sh * chore: apply patch_9_mesosphere_helmignore.sh * chore: apply patch_10_mesosphere_patch_storage.sh * chore: helm dependency update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdolbey msdolbey msdolbey approved these changes

Assignees

@gracedo gracedo

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gracedo @msdolbey