Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump reloader to 1.0.116 #2420

Closed
wants to merge 12 commits into from
Closed

Conversation

mesosphere-ci
Copy link
Contributor

Upgrades the following apps to use version 1.0.116 of chart reloader:

  • reloader from version 1.0.107 to 1.0.116

@github-actions github-actions bot added services/reloader size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
@coveralls
Copy link

coveralls commented Jul 16, 2024

Pull Request Test Coverage Report for Build 10264700778

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%

Totals Coverage Status
Change from base Build 10229166454: 0.0%
Covered Lines: 136
Relevant Lines: 264

💛 - Coveralls

@gracedo gracedo added update-licenses signals mergebot to update licenses.d2iq.yaml and removed update-licenses signals mergebot to update licenses.d2iq.yaml labels Jul 17, 2024
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116

@gracedo gracedo closed this Jul 17, 2024
@gracedo gracedo reopened this Jul 17, 2024
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2024
@shubham2g shubham2g self-assigned this Jul 17, 2024
@shubham2g shubham2g added ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Jul 17, 2024
@gracedo gracedo assigned tushar-wagh-nx and unassigned shubham2g Jul 29, 2024
@gracedo gracedo mentioned this pull request Jul 29, 2024
2 tasks
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116

@gracedo
Copy link
Contributor

gracedo commented Jul 30, 2024

There is something wrong with the script, the versions are getting completely removed instead of updated now: https://github.com/mesosphere/kommander/pull/4890/files

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2024
@tushar-wagh-nx tushar-wagh-nx added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Jul 30, 2024
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116

@gracedo
Copy link
Contributor

gracedo commented Jul 31, 2024

@tushar-wagh-nx btw this is the PR that has been created from the script that you updated https://github.com/mesosphere/kommander/pull/4897 - as you can see it actually resulted in no changes, when the app versions should have been bumped in test files. To re-test your script you just need to delete the kommander PR/branch and re-run the workflow here to recreate the kommander PR

Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116

@gracedo
Copy link
Contributor

gracedo commented Jul 31, 2024

@tushar-wagh-nx Somehow this PR has lost the actual bump commits that upgrades the version of reloader in this PR. This is why the CI on corresponding kommander PR is not failing (there is actually no reloader version bump)

@SandhyaRavi2403 SandhyaRavi2403 added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116

Copy link
Contributor

github-actions bot commented Aug 5, 2024

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116

@tushar-wagh-nx tushar-wagh-nx added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Aug 6, 2024
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116

@gracedo
Copy link
Contributor

gracedo commented Aug 19, 2024

superseded by #2503

@gracedo gracedo closed this Aug 19, 2024
@gracedo gracedo deleted the chartbump/reloader-1.0.116 branch August 19, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/reloader size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants