-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump reloader to 1.0.116 #2420
Conversation
Pull Request Test Coverage Report for Build 10264700778Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116 |
This reverts commit b6c530b.
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116 |
There is something wrong with the script, the versions are getting completely removed instead of updated now: https://github.com/mesosphere/kommander/pull/4890/files |
1d059d9
to
60ad622
Compare
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116 |
@tushar-wagh-nx btw this is the PR that has been created from the script that you updated https://github.com/mesosphere/kommander/pull/4897 - as you can see it actually resulted in no changes, when the app versions should have been bumped in test files. To re-test your script you just need to delete the kommander PR/branch and re-run the workflow here to recreate the kommander PR |
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116 |
@tushar-wagh-nx Somehow this PR has lost the actual bump commits that upgrades the version of reloader in this PR. This is why the CI on corresponding kommander PR is not failing (there is actually no reloader version bump) |
144ae17
to
3a5afba
Compare
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116 |
91fc878
to
7899270
Compare
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116 |
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/reloader-1.0.116 |
superseded by #2503 |
Upgrades the following apps to use version 1.0.116 of chart reloader: