LG notebook - Repair broken import and add note about dependency #667
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreso
approved these changes
Sep 10, 2024
| "The code below shows a workflow for evaluating the model using Toxic Chat. ToxicChat is provided as an example dataset. It is recommended that an dataset chosen specifically for the application be used to evaluate fine-tuning success. ToxicChat can be used to evaluate any degredation in standard category performance caused by the fine-tuning. \n" | ||
| "The code below shows a workflow for evaluating the model using Toxic Chat. ToxicChat is provided as an example dataset. It is recommended that an dataset chosen specifically for the application be used to evaluate fine-tuning success. ToxicChat can be used to evaluate any degredation in standard category performance caused by the fine-tuning. \n", | ||
| "\n", | ||
| "Note: This code relies on the llama package. To install if this is not yet installed: ```git clone https://github.com/meta-llama/llama/;cd llama;pip install -e .```\n" |
There was a problem hiding this comment.
I think we're not expecting people to alter the llama code, right? So why not just install through without cloning and install editable:
Suggested change
| "Note: This code relies on the llama package. To install if this is not yet installed: ```git clone https://github.com/meta-llama/llama/;cd llama;pip install -e .```\n" | |
| "Note: This code relies on the llama package. To install if this is not yet installed: ```pip install git+https://github.com/meta-llama/llama/ .```\n" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve an import issue and add a note explaining the dependency of the Evaluation section of the notebook on the llama package