Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vis block #528

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Fix vis block #528

merged 6 commits into from
Oct 26, 2023

Conversation

QuanyiLi
Copy link
Member

What changes do you make in this PR?

Remove the destroy() in __del__ function. It is not allowed to use destroy in __del__ in the future!

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@github-actions
Copy link

[BOT] Great job! You have changed the docstring coverage from 27.00% to 27.06%, improving 0.065%.

@github-actions
Copy link

[BOT] Great job! You have changed the docstring coverage from 27.00% to 27.06%, improving 0.065%.

@pengzhenghao
Copy link
Member

Oh sh! I merge a similar PR to this one?? #529

# Conflicts:
#	metadrive/tests/vis_block/vis_in_ramp.py
#	metadrive/tests/vis_block/vis_intersection.py
#	metadrive/tests/vis_block/vis_out_ramp.py
#	metadrive/tests/vis_block/vis_roundabout.py
#	metadrive/tests/vis_block/vis_std_intersection.py
#	metadrive/tests/vis_block/vis_std_t_intersection.py
#	metadrive/tests/vis_block/vis_straight_block.py
#	metadrive/tests/vis_block/vis_t_intersection.py
@github-actions
Copy link

[BOT] Great job! You have changed the docstring coverage from 27.26% to 27.32%, improving 0.065%.

@pengzhenghao
Copy link
Member

OK All fixed

@QuanyiLi
Copy link
Member Author

Shall I merge this PR?

@QuanyiLi QuanyiLi merged commit 6369b70 into main Oct 26, 2023
11 checks passed
@QuanyiLi QuanyiLi deleted the fix-vis-block branch October 26, 2023 12:27
@github-actions
Copy link

[BOT] Great job! You have changed the docstring coverage from 27.32% to 27.32%, improving 0.000%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants