Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flux variables #124

Merged
merged 26 commits into from
Sep 6, 2023
Merged

Use flux variables #124

merged 26 commits into from
Sep 6, 2023

Conversation

katauber
Copy link
Member

Instead of using PG_DATA, fixand morph commands, use flux variables.
Closes #114, #70, #63

katauber and others added 22 commits July 14, 2023 09:50
@katauber
Add the Java Security Manager
ee3014d
@katauber
Add permission to connect to URLs to get input data
12567ed
@Phu2 @katauber
Add JSM permissions needed by Fix
eacf1d7
@Phu2 @katauber
Add JSM permission needed by triples functions
88ca936 
eg. org.metafacture.triples.TripleSort
try example "workshop>sample9 Enrich"
@katauber @fsteeg
Fix grammar in README.md
d83019b 
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@katauber @fsteeg
Fix typo in resources/.java.policy_move_to_home_dir
5c76adc 
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@katauber @fsteeg
Fix grammar in resources/.java.policy_move_to_home_dir
1a967b8 
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@katauber
[WIP] Use variables to avoid replacing. See #114
3b249d7
@katauber
Merge branch '114-useFluxVariables' of https://github.com/metafacture…
7813ea7 
…/metafacture-playground into 114-useFluxVariables
@katauber
[WIP] Use variables to avoid replacing. See #114
94a4fb4
@katauber
Merge branch '114-useFluxVariables' of https://github.com/metafacture…
60c5e7f 
…/metafacture-playground into 114-useFluxVariables
@katauber
Use flux variables. See #114
ad95ea0
@katauber
Adapt examples to use of flux variables. See #114
a37c3a3
@katauber
Fix version link of metafacture-framework. See #114
0885adc
@katauber
Move result to other editors in db. See #114
cb8e945
@katauber
Fix process test to run with variables. See #114
ebc3680
@katauber
Adapt metafacture framework version. See #114
25445b1
@katauber
Rename variables after review. See #114
7945645
@katauber
Temporary add metafacture-core build to actions.
c2daaaf
@katauber
Add Java version to Github actions.
4e08317
@katauber
Update metafacture-core to 5.6.0 and metafacture-fix to 0.6.1. See #114
f1acb95
@katauber
Update fix version in README. See #114
d9c30ff
@TobiasNx TobiasNx requested a review from fsteeg September 1, 2023 12:43
fsteeg
fsteeg approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, also export & import, and yay for −141 lines!

Added some minor suggestions inline.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
resources/examples/How_to_use_the_Playground Outdated Show resolved Hide resolved
resources/examples/Local_formeta_to_XML_(morph) Show resolved Hide resolved
src/cljs/metafacture_playground/db.cljs Outdated Show resolved Hide resolved
@fsteeg fsteeg assigned katauber and unassigned fsteeg Sep 4, 2023
@katauber @fsteeg
Apply suggestions from code review. See #114
d590fa5 
Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@katauber katauber merged commit dd3846a into main Sep 6, 2023
2 checks passed
@katauber katauber deleted the 114-useFluxVariables branch September 6, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasNx TobiasNx TobiasNx left review comments

@fsteeg fsteeg fsteeg approved these changes

Assignees

@katauber katauber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't replace content in Flux, use variables instead
4 participants
@katauber @fsteeg @TobiasNx @Phu2