-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dualstack Network Support #549
base: master
Are you sure you want to change the base?
Conversation
…o ipv6-support
…o ipv6-support
5919c8f
to
0c53831
Compare
0c53831
to
2389965
Compare
…o dualstack-support
d49d2c0
to
b65c835
Compare
23a3d1e
to
89096c0
Compare
…o dualstack-support
a3571a2
to
d9667d3
Compare
Vrf *uint `json:"vrf" description:"the vrf this network is associated with" optional:"true"` | ||
VrfShared *bool `json:"vrfshared" description:"if set to true, given vrf can be used by multiple networks, which is sometimes useful for network partitioning (default: false)" optional:"true"` | ||
ParentNetworkID *string `json:"parentnetworkid" description:"the id of the parent network" optional:"true"` | ||
AddressFamilies metal.AddressFamilies `json:"addressfamilies" description:"the addressfamilies in this network, either IPv4 or IPv6 or both"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better introduce a map from AF:Struct which contains defaultchildprefixlenght and usage, deprecate usage.
type FamilyInfo struct {
defaultchildprefixlength uint8
usage metal.NetworkUsage
}
type FamilyInfos map[AddressFamily]FamilyInfo
Check for available AFs is missing here |
Also for invalid CIDRs in firewall rules we actually return:
|
Firewall installation fails with ingress rules with to and from specified
rules:
|
…, return a ipv6 address
Done |
Fixed |
Closes #164
Actions Required
Depends on:
replaces #544
TODO: