Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix IPA git commit/branch refference #870

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix IPA git commit/branch refference #870

merged 1 commit into from
Jan 3, 2025

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Oct 1, 2024

This commit:

  • Fixes an icorrect value assignment for IPA repository refference This bug was causing the build tooling to not check out the specified IPA branch instead it was checking out the mian
  • Adds missing IPA repository address variable

@Rozzii
fix IPA git commit/branch refference
db031ec 
This commit:
 - Fixes an icorrect value assignment for IPA repository refference
   This bug was causing the build tooling to not check out the specified IPA
   branch instead it was checking out the mian
 - Adds missing IPA repository address variable

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Oct 1, 2024

/test metal3-ubuntu-e2e-integration-test-main

Sunnatillo
Sunnatillo reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Oct 1, 2024

/test ?

@metal3-io-bot
Copy link
Collaborator

@Rozzii: The following commands are available to trigger required jobs:

  • /test check-prow-config
  • /test markdownlint
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck

The following commands are available to trigger optional jobs:

  • /test metal3-bml-integration-test-centos
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-centos-e2e-basic-test-release-1-7
  • /test metal3-centos-e2e-basic-test-release-1-8
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-centos-e2e-feature-test-release-1-6-features
  • /test metal3-centos-e2e-feature-test-release-1-6-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-6-remediation
  • /test metal3-centos-e2e-feature-test-release-1-7-features
  • /test metal3-centos-e2e-feature-test-release-1-7-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-7-remediation
  • /test metal3-centos-e2e-feature-test-release-1-8-features
  • /test metal3-centos-e2e-feature-test-release-1-8-pivoting
  • /test metal3-centos-e2e-feature-test-release-1-8-remediation
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-centos-e2e-integration-test-release-1-6
  • /test metal3-centos-e2e-integration-test-release-1-7
  • /test metal3-centos-e2e-integration-test-release-1-8
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-centos-release-1-6
  • /test metal3-dev-env-integration-test-centos-release-1-7
  • /test metal3-dev-env-integration-test-centos-release-1-8
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-dev-env-integration-test-ubuntu-release-1-6
  • /test metal3-dev-env-integration-test-ubuntu-release-1-7
  • /test metal3-dev-env-integration-test-ubuntu-release-1-8
  • /test metal3-e2e-1-28-1-29-upgrade-test-release-1-6
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-7
  • /test metal3-e2e-1-29-1-30-upgrade-test-release-1-8
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-6
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-7
  • /test metal3-e2e-clusterctl-upgrade-test-release-1-8
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-7
  • /test metal3-ubuntu-e2e-basic-test-release-1-8
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-6-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-7-remediation
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-features
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-pivoting
  • /test metal3-ubuntu-e2e-feature-test-release-1-8-remediation
  • /test metal3-ubuntu-e2e-integration-test-release-1-6
  • /test metal3-ubuntu-e2e-integration-test-release-1-7
  • /test metal3-ubuntu-e2e-integration-test-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • check-prow-config
  • shellcheck

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

tuminoid commented Oct 1, 2024

This is not tested by integration job, but fullstack. Fullstack isn't enabled for this repo though, so we need to change prow config to add it first, then run it here.

@tuminoid
Copy link
Member

tuminoid commented Oct 1, 2024

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Oct 1, 2024

Okay it looks like metal3-ubuntu-e2e-integration-test-main is not a relevant test here.
We have test job for testing IPA builder PRs but it is not assigned to this repo.
/hold
I will assign the test to the repo.

@Rozzii
Copy link
Member Author

Rozzii commented Oct 1, 2024

/test-metal3-fullstack

@Rozzii
Copy link
Member Author

Rozzii commented Oct 1, 2024 •
edited
Loading

The fullstack PR test still has the legacy ghprb trigger logic in its pipeline code so I will upgrade it to use prow.

@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Dec 30, 2024

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Jan 3, 2025 •
edited
Loading

I have thought about this and although it can be only tested by fullstack but fullstack is not yet working with prow, this can be only tested by the periodic fullstack.

IMO this can be merged, I have tested the build script manually it does not break the build other than that it has no effect, in worst case scenario it breaks the fullstack but nothing relies on fullstack so this would have no effect cascading effect on CI .
/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Jan 3, 2025

/cc @adilGhaffarDev @mquhuy

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@metal3-io-bot metal3-io-bot merged commit f99cd8a into metal3-io:main Jan 3, 2025
7 checks passed
@metal3-io-bot metal3-io-bot deleted the ipa_commit_fix branch January 3, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid Awaiting requested review from tuminoid

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rozzii @metal3-io-bot @tuminoid @adilGhaffarDev @Sunnatillo