Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line comments instead of block comments 10 #149

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

GinoGiotto
Copy link
Contributor

Continuation of #138

This PR covers the mmpfas.c file. Only the header, a few inline comments and /*E*/ comments are left out.

@GinoGiotto
Copy link
Contributor Author

There are currently no merge conflicts, but since comments are widespread throughout the code, these pending PRs might create complications for future commits. @digama0

src/mmpfas.c Outdated Show resolved Hide resolved
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@GinoGiotto
Copy link
Contributor Author

Can we review these PRs? They've been pending for months and I'd like to avoid potential merge conflicts. @digama0

src/mmpfas.c Show resolved Hide resolved
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@digama0 digama0 merged commit dcbbc08 into metamath:master Aug 31, 2023
2 checks passed
@GinoGiotto GinoGiotto deleted the mmpfas branch September 1, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants