Add pubkeys #3
Open
Add pubkeys #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstepanovdev
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Unfortunately, adding a dependency and casting may be redundant. Declaring constants might be done client-side without adding a dependency for the crate. That dependency will not bloat the source, albeit it will add additional dependency indirection level which can be hard to resolve in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds pubkeys to the repo.
Why
If crate which imports this constants uses same solana-program version it can import Pubkeys. But if solana version are different it can import raw keys, no compilation errors in such case. It was tested with solana versions 1.18.15 and 2.0