Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default values #72

Closed
wants to merge 11 commits into from
Closed

Support default values #72

wants to merge 11 commits into from

Conversation

rustworthy
Copy link
Contributor

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings // N/A

Adding support for fallback values: primitives and arrays of primitives with tests covering numbers, strings, and arrays of strings.

NB! This is a remastered version of previously submtted PR. Though doing the same thing (enabling default values), does it in a slightly different and probably more efficient manner: parsing default values once on the tickplate init stage, rather than each time the template is being used. If all the ticklates needed for the application are instantiated at app start-up time and them re-used with new and new data coming in (which I suppose they are), this implemention will be more performant.

@rustworthy rustworthy mentioned this pull request Sep 18, 2023
5 tasks
@rustworthy rustworthy changed the title Support default values [REMASTERED] Support default values Oct 29, 2023
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add metautil ad dependency

tickplate.js Outdated Show resolved Hide resolved
tickplate.js Show resolved Hide resolved
tshemsedinov pushed a commit that referenced this pull request Nov 7, 2023
tshemsedinov pushed a commit that referenced this pull request Nov 7, 2023
@tshemsedinov
Copy link
Member

Landed in 28989e0 and af59e49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants