-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default values #72
Closed
rustworthy
wants to merge
11
commits into
metarhia:master
from
rustworthy:feat/default-values-remastered
Closed
Support default values #72
rustworthy
wants to merge
11
commits into
metarhia:master
from
rustworthy:feat/default-values-remastered
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustworthy
changed the title
Support default values [REMASTERED]
Support default values
Oct 29, 2023
tshemsedinov
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add metautil ad dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm t
)npm run fmt
)Adding support for fallback values: primitives and arrays of primitives with tests covering numbers, strings, and arrays of strings.
NB! This is a remastered version of previously submtted PR. Though doing the same thing (enabling default values), does it in a slightly different and probably more efficient manner: parsing default values once on the tickplate init stage, rather than each time the template is being used. If all the ticklates needed for the application are instantiated at app start-up time and them re-used with new and new data coming in (which I suppose they are), this implemention will be more performant.