-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: anonymised telemetry to track usage patterns #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
why are new formatting changes getting introduced? I think yours look right, but not sure how the current code got committed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just +1ing @vatsalaggarwal's other extra metrics
properties = { | ||
**config, | ||
**model_args, | ||
"train": str(train), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd also be interesting to know:
- How much data (minutes ideal, row count ok) in datasets
- What % of the network is being finetuned - we're already somewhat tracking this via
last_n_blocks_to_finetune
being captured but wouldn't cover any custom logic changes - a quick sum of trainable params before finetuning starts vs their config settings would let us observe that custom network changes were made (interesting data point). - Hardware being used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.