Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of components imported from other files #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nathan-muir
Copy link

@nathan-muir nathan-muir commented Mar 29, 2022

currently, importing a component from another file does not work, eg;

In main.vue

<script setup>
import Other from './other.vue';
</script>
<template>
   <Other />
</template>

In other.vue

<template>
   <div>Other Component</div>
</template>

After investigation, this is because the template-compiler isn't aware that Other is an imported component, so the template code is generating resolveComponent("Other") instead of createVNode(Other).

The fix is simply to tell the template compiler about the variables exported from the setup script (via bindingMetadata)

Be aware; When testing, meteor will keep caching files even if the compiler is updated, it's useful to run meteor reset after changing the compiler so that all files are built with the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant