Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to model_cfg to use getter function #1424

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Nov 25, 2024

Change Summary

ModelMapsEngine had not been updated to use the getter function for model_names.

Related issue number

NA, see chat with Charlie

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@lewisblake lewisblake added the bug 🐛 Something isn't working label Nov 25, 2024
@lewisblake lewisblake added this to the m2024-12 milestone Nov 25, 2024
@lewisblake lewisblake self-assigned this Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (aa4c23e) to head (8d55c2b).
Report is 3 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/modelmaps_engine.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1424      +/-   ##
============================================
+ Coverage     78.35%   78.58%   +0.22%     
============================================
  Files           137      137              
  Lines         20889    20889              
============================================
+ Hits          16367    16415      +48     
+ Misses         4522     4474      -48     
Flag Coverage Δ
unittests 78.58% <80.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lewisblake lewisblake marked this pull request as ready for review November 25, 2024 12:18
@lewisblake lewisblake merged commit 232a3c9 into main-dev Nov 25, 2024
8 checks passed
@lewisblake lewisblake deleted the charlie_work branch November 25, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants