Support Cylc 8 #33
Merged
Support Cylc 8 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpmatthews
commented
Mar 26, 2024
Comment on lines
+36
to
+37
| apt-get install -q -y subversion chromium-browser tkcvs tk libxml-parser-perl || error | ||
| xdg-settings set default-web-browser chromium-browser.desktop |
There was a problem hiding this comment.
The Cylc 8 graph view seems to have weird display issues with Firefox on the Ubuntu 22.04 VM (never seen this issue with Firefox anywhere else). Switching to Chromium for the moment.
dpmatthews
commented
Mar 26, 2024
Comment on lines
+131
to
+134
| # Insecure workaround for browser permissions error | ||
| # See https://stackoverflow.com/questions/70753768/jupyter-notebook-access-to-the-file-was-denied | ||
| mkdir -p /opt/metomi-site/etc/cylc/uiserver | ||
| dos2unix -n /vagrant/opt/metomi-site/etc/cylc/uiserver/jupyter_config.py /opt/metomi-site/etc/cylc/uiserver/jupyter_config.py |
There was a problem hiding this comment.
This workaround exposes the auth token in the process list so would not be appropriate on a shared system.
dpmatthews
commented
Mar 26, 2024
Comment on lines
-199
to
-203
| #### Configure firefox as the default PDF viewer | ||
| sudo -u $(logname) mkdir -p /home/vagrant/.local/share/applications | ||
| sudo -u $(logname) bash -c 'echo "[Added Associations]" >/home/vagrant/.local/share/applications/mimeapps.list' | ||
| sudo -u $(logname) bash -c 'echo "application/pdf=firefox.desktop;" >>/home/vagrant/.local/share/applications/mimeapps.list' | ||
|
|
There was a problem hiding this comment.
I suspect this was only added to allow viewing of the old PDF versions of the documentation which we no longer produce.
dpmatthews
commented
Mar 27, 2024
| @@ -85,10 +85,10 @@ else | |||
| echo "[INFO] No errors detected" | |||
| fi | |||
|
|
|||
| if [[ $collections =~ desktop ]]; then | |||
| rm -f /etc/nologin | |||
| if [[ $collections =~ desktop && ! $collections =~ skip-shutdown ]]; then | |||
There was a problem hiding this comment.
Shutting down and then restarting was wasting time in github actions and also causing some failures which I couldn't explain so I've added this crude method to skip the shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.