Skip to content

Commit

Permalink
Updated plugins and dependencies versions in pom.xml (#128)
Browse files Browse the repository at this point in the history
* updated maven dependencies

* updated maven plugin versions in pom.xml

* updated pom.xml dependencies and plugin versions

* updated seleniumdevtools log version

* updated codeql versions

* removed browser version from lambdatest cloud browser setup so the tests run on latest browsers
  • Loading branch information
mfaisalkhatri authored Dec 19, 2023
1 parent 1b5b8e8 commit 548f710
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 19 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v1
uses: github/codeql-action/autobuild@v2

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Expand All @@ -78,4 +78,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
uses: github/codeql-action/analyze@v2
47 changes: 33 additions & 14 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<selenium.java.version>4.11.0</selenium.java.version>
<selenium.java.version>4.16.1</selenium.java.version>
<testng.version>7.8.0</testng.version>
<webdrivermanager.version>5.5.2</webdrivermanager.version>
<commons-io.version>2.13.0</commons-io.version>
<webdrivermanager.version>5.6.2</webdrivermanager.version>
<commons-io.version>2.15.1</commons-io.version>
<log4jcore.version>2.20.0</log4jcore.version>
<log4japi.version>2.20.0</log4japi.version>
<orgjson.version>20230618</orgjson.version>
<orgjson.version>20230618</orgjson.version>
<seleniumdevtools.version>4.11.0</seleniumdevtools.version>
<lombok.version>1.18.28</lombok.version>
<datafaker.version>2.0.1</datafaker.version>
<maven.compiler.version>3.11.0</maven.compiler.version>
<surefire-version>3.1.2</surefire-version>
<orgjson.version>20231013</orgjson.version>
<seleniumdevtools.version>4.16.1</seleniumdevtools.version>
<lombok.version>1.18.30</lombok.version>
<datafaker.version>2.0.2</datafaker.version>
<maven-enforcer-plugin.version>3.4.1</maven-enforcer-plugin.version>
<maven.compiler.version>3.12.0</maven.compiler.version>
<surefire-version>3.2.3</surefire-version>
<java.release.version>17</java.release.version>
<maven.source.encoding>UTF-8</maven.source.encoding>
<suite-xml>test-suite/testng.xml</suite-xml>
Expand All @@ -38,9 +38,9 @@
<sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/target/site/jacoco/jacoco.xml
</sonar.coverage.jacoco.xmlReportPaths>
<sonar.java.source>15</sonar.java.source>
<jacoco.version>0.8.10</jacoco.version>
<jacoco.version>0.8.11</jacoco.version>
<sonarjacocolistener.version>5.14.0.18788</sonarjacocolistener.version>
<sonarmavenplugin.version>3.9.1.2184</sonarmavenplugin.version>
<sonarmavenplugin.version>3.10.0.2594</sonarmavenplugin.version>
</properties>
<dependencies>
<!-- https://mvnrepository.com/artifact/org.seleniumhq.selenium/selenium-java -->
Expand Down Expand Up @@ -99,7 +99,7 @@
<!-- https://mvnrepository.com/artifact/org.seleniumhq.selenium/selenium-devtools-v101 -->
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-devtools-v113</artifactId>
<artifactId>selenium-devtools-v120</artifactId>
<version>${seleniumdevtools.version}</version>
</dependency>
<!-- https://mvnrepository.com/artifact/org.projectlombok/lombok -->
Expand All @@ -109,7 +109,6 @@
<version>${lombok.version}</version>
<scope>provided</scope>
</dependency>

</dependencies>
<build>
<plugins>
Expand Down Expand Up @@ -148,6 +147,26 @@
<argLine>${argLine}</argLine>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>${maven-enforcer-plugin.version}</version>
<executions>
<execution>
<id>enforce-maven</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireMavenVersion>
<version>3.2.5</version>
</requireMavenVersion>
</rules>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import org.openqa.selenium.chrome.ChromeDriver;
import org.openqa.selenium.chrome.ChromeOptions;
import org.openqa.selenium.devtools.DevTools;
import org.openqa.selenium.devtools.v113.log.Log;
import org.openqa.selenium.devtools.v120.log.Log;

/**
* Created By Faisal Khatri on 21-03-2022
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ private static void setupChromeDriver () {
private static void setupChromeInLambdaTest () {
final var browserOptions = new ChromeOptions ();
browserOptions.setPlatformName ("Windows 10");
browserOptions.setBrowserVersion ("114.0");
browserOptions.setCapability ("LT:Options", ltOptions ());
try {
setDriver (
Expand Down Expand Up @@ -157,7 +156,6 @@ private static void setupFirefoxDriver () {
private static void setupFirefoxInLambdaTest () {
final var browserOptions = new FirefoxOptions ();
browserOptions.setPlatformName ("Windows 10");
browserOptions.setBrowserVersion ("114.0");
browserOptions.setCapability ("LT:Options", ltOptions ());
try {
setDriver (
Expand Down

0 comments on commit 548f710

Please sign in to comment.