-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams #27
Open
mgravell
wants to merge
17
commits into
master
Choose a base branch
from
streams
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize for array-backed, which seems reasonable (we can't hold a span in this context, and a memory is expensive to keep calling .Span on)
…ady* implemented as a linked list - use that for the impl
…sm in stream tests (impacts lease counts)
…s and full unwrap)
…ng arenas and full unwrap)" This reverts commit 392b1bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
SequenceStream
/ReadOnlySequenceStream
pair - similar toMemoryStream
, but:GetBuffer()
returns[ReadOnly]Sequence<byte>
ArrayPool<byte>.Shared
and returns them when trimmed/disposedBenefits:
SequenceStream
owns the sequence, so it can play with the chain; it does not mutate the chain if an existing one is passed in)Sequence<byte>
orReadOnlySequence<byte>
as aStream
with very low overheadMemoryStream
anyway (I'd have settled for "equal or slightly worse")Possible additions:
ArrayPool<byte>
to be specified? or is that unnecessary?MemoryPool<byte>[.Shared]
instead ofArrayPool<byte>
?Performance: