-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data table implementation #261
Open
mgreminger
wants to merge
83
commits into
main
Choose a base branch
from
data-table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP, when complete, will close #252
…esults Expression is not evaluated correctly, results can be queried but are not yet displayed in the table
This will allow data table results to be assembled
Still need to implement rendering of data table query results on the front end
…data table Need to fix get_data_table_subs tree walking algorithm and rendering of units in data table for calculated columns
Also, fix parsing of assign_plus_query for data tables
Also, don't parse column expression for output columns
HTML inputs add this unicode character
Need to implement interpolation and polyfit capabilities in Python
Still need to add the poly order widget to the datatable
Currently there are issues with the DOM updating properly after the import Might make more sense to use a constructor to create a new datatable cell rather than try to change the current one.
Still need to fix initial refresh problem by converting selectAndLoadSpreadsheetFile to a promise
Need to wait for sheetjs to be loaded before attempting to fill out table
…nput and error handling
Need to convert units to a human readable format
Also, rename the original table cell to selector table cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
When complete, will close #252