Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nomaterial branch #253

Draft
wants to merge 29 commits into
base: nomaterial
Choose a base branch
from
Draft

Update nomaterial branch #253

wants to merge 29 commits into from

Conversation

andi34
Copy link

@andi34 andi34 commented Jan 17, 2024 •
edited
Loading

Fixes #227

  • Cherry-Picked applying commits from master branch to get in sync
  • updated Docker file:
    • use python:3.11-alpine3.18
    • removed unneeded run line
  • updated example for nomaterial action
  • install mkdocs by default, no need for an own requirements.txt now
  • updated action example to use checkout@v4

János Pásztor and others added 25 commits January 17, 2024 06:50
Added comment about not using the material theme. (mhausenblas#42)
b2ebceb 
Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>
@RammusXu
Bump example actions/checkout@v2 (mhausenblas#68)
482a709 
Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>
@RammusXu
Fix shell check (mhausenblas#69)
0a362a9 
Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>
@madwort
Support multiple package names in EXTRA_PACKAGES (mhausenblas#74)
5992954 
* I think this will fix mhausenblas#73

Signed-off-by: Tom Ward <tomward@fmail.co.uk>
@mhausenblas
fixes build
a7c89aa 
Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>
@afritzler
Added custom github domain support (mhausenblas#84)
e8165b8 
Signed-off-by: Andreas Fritzler <andreas.fritzler@sap.com>
@afritzler
Fixed formatting in readme (mhausenblas#86)
0dd60b3 
Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>
@Joffref
/action.sh: line 42: git: command not found (mhausenblas#88)
485b947 
Since 1.18, the addition of ${GITHUB_DOMAIN:-github.com} make error occurs in execution of the workflow.

I propose to modify ; ${GITHUB_DOMAIN:-github.com} to ${GITHUB_DOMAIN:-'github.com'}

Source : https://tldp.org/LDP/abs/html/parameter-substitution.html
Issue ref : mhausenblas#87
@hiddeco
Replace apostrophe with quote (mhausenblas#90)
beffe57 
Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>
@madwort
Fix multiple $EXTRA_PACKAGES (mhausenblas#109)
a8b5e22
@cristiklein
Add lint mode (mhausenblas#120)
1d39e63 
Signed-off-by: Cristian Klein <cristian.klein@elastisys.com>
@dependabot
Bump actions/checkout from v2.3.3 to v2.3.4 (mhausenblas#44)
2ec5493 
Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.3 to v2.3.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.3...5a4ac90)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/checkout from 2.3.4 to 2.3.5 (mhausenblas#127)
48a8883 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.4...v2.3.5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rekire
Explain how mkdocs plugins are supported (mhausenblas#130)
1b51308 
I found no reference how to install the required dependencies. This feature is already there but not documented, so I extended the README file.

Out of my view this resolves mhausenblas#12, mhausenblas#53 and mhausenblas#97

Signed-off-by: rekire <git@reki.re>
@dependabot
Bump actions/checkout from 2.3.5 to 2.4.0 (mhausenblas#133)
3fd52ec 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.5...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/checkout from 2.4.0 to 3.0.1 (mhausenblas#164)
6a580e6 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.4.0...v3.0.1)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/checkout from 3.0.1 to 3.0.2 (mhausenblas#165)
418b051 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pascaliske
fix: set workspace as safe directory (mhausenblas#183)
f73f101 
More information here: actions/checkout#766

Signed-off-by: Pascal Iske <info@pascaliske.dev>
@quad
Lint using the specified CONFIG_FILE (mhausenblas#191)
7871702 
Signed-off-by: Scott Robinson <ssr@squareup.com>

Signed-off-by: Scott Robinson <ssr@squareup.com>
@IoriBranford
Add note to give write permission to GITHUB_TOKEN (mhausenblas#226)
88006cf 
Signed-off-by: IoriBranford <ioribranford@gmail.com>
@dalonsoa
Remove forcing strict mode (mhausenblas#199)
29b2c19 
Signed-off-by: Diego <d.alonso-alvarez@imperial.ac.uk>
@timlinux
Update Dockerfile (mhausenblas#247)
f0a9242
@andi34
Dockerfile: use python:3.11-alpine3.18
5dda37a
@andi34
Dockerfile: merge RUN lines
d3f852f
@andi34
README: use nomaterial in example
4c36d1c 
Signed-off-by: Andreas Blaesius <andi@unlegacy-android.org>
@andi34
Copy link
Author

andi34 commented Jan 17, 2024

Add also required mkdocs by default?

@andi34
Copy link
Author

andi34 commented Jan 17, 2024 •
edited
Loading

Used on https://github.com/PhotoboothProject/PhotoboothProject.github.io

https://photoboothproject.github.io/

@andi34
action.sh: allow to change origin
737290d 
It's not possible to override a default environment variable
@andi34 andi34 marked this pull request as draft September 5, 2024 18:41
@andi34
Copy link
Author

andi34 commented Sep 5, 2024

Made draft because of personal changes since this PR was never reviewed and no feedback given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.