Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework data logging interfaces #78

Merged
merged 36 commits into from
Dec 3, 2023

tests: Allow a bit more timestamp deviation in data logging write test

a4b7cad
Select commit
Loading
Failed to load commit list.
Merged

Rework data logging interfaces #78

tests: Allow a bit more timestamp deviation in data logging write test
a4b7cad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2023 in 0s

83.13% (+1.76%) compared to 27cddbe

View this Pull Request on Codecov

83.13% (+1.76%) compared to 27cddbe

Details

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (27cddbe) 81.36% compared to head (a4b7cad) 83.13%.

Files Patch % Lines
shc/interfaces/mysql.py 75.26% 38 Missing and 8 partials ⚠️
shc/data_logging.py 88.12% 22 Missing and 9 partials ⚠️
shc/interfaces/in_memory_data_logging.py 85.18% 4 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   81.36%   83.13%   +1.76%     
==========================================
  Files          43       42       -1     
  Lines        5389     5526     +137     
  Branches      809      850      +41     
==========================================
+ Hits         4385     4594     +209     
+ Misses        798      714      -84     
- Partials      206      218      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov