Removed deprecated twig tags #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@basdenooijer Hello, thanks for the PR! Can you please also adjust the tests in https://github.com/mhujer/BreadcrumbsBundle/blob/master/Test/BundleTest.php? You can run them locally with |
|
Sure, I was a bit in rush with the fix so completely missed the tests. Just pushed an update. Shortly looked into comparing the HTML independent of the whitespace in the template, but there doesn't seem to be an easy way to do this. Introducing a (dev) dependency just for this seemed overkill. |
mhujer
reviewed
Sep 16, 2024
| @@ -72,8 +90,23 @@ public function testRenderingTranslationWithParametersAndTranslationDomain() | |||
| /** @var \WhiteOctober\BreadcrumbsBundle\Twig\Extension\BreadcrumbsExtension $breadcrumbsExtension */ | |||
| $breadcrumbsExtension = $container->get('white_october_breadcrumbs.twig'); | |||
|
|
|||
| self::assertSame( | |||
| '<ol id="wo-breadcrumbs" class="breadcrumb" itemscope itemtype="http://schema.org/BreadcrumbList"><li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem"><span itemprop="name">foo__domain:admin</span><meta itemprop="position" content="1" /><span class=\'separator\'>/</span></li><li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem"><span itemprop="name">bar__{name:John}__domain:admin</span><meta itemprop="position" content="2" /></li></ol>', | |||
| self::assertStringEqualsStringIgnoringLineEndings( | |||
There was a problem hiding this comment.
Oh nice, I didn't know that this one existed! 👍
|
@basdenooijer Thank you! Merged and tagged as |
|
Great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spacelessfilterRelated to #39