refactor: Upgraded to h3 => v1.8.0 dependency in nitro-cors.

[michealroberts]

refactor: Upgraded to h3 => v1.8.0 dependency in nitro-cors.

Includes refactor to utilise the new EventHandlerRequest type from h3 v1.8.0 rather than any.

Includes refactor to deprecate the getMethod() utility in favour of event.method with h3 v1.8.0.

[danielroe]

Looks good to me. If you are able to verify inferred types are working well, that would be great. (Could maybe add a type fixture too just to confirm but that could be beyond the scope.)

[michealroberts]

Looks good to me. If you are able to verify inferred types are working well, that would be great. (Could maybe add a type fixture too just to confirm but that could be beyond the scope.)

Hey @danielroe , this would be cool.

I've taken a look at attempting to mock the H3 Event to check types, I need to mock the ServerResponse, but have had varying levels of success, do you know how this could be mocked?

I've tried this:

it('should return the correct types when specified', async () => {
      const handler = defineCORSEventHandler(
        async event => {
          return {
            cors: true
          }
        },
        {
          origin: '*',
          methods: '*'
        }
      )

      const req = new IncomingMessage(new Socket())

      const res = await handler(createEvent(req, {} as H3Event['res']))

      expectTypeOf(res).toEqualTypeOf<{
        cors: boolean
      }>()
    })

But the test is failing to append response headers (obviously, as it is dummy mocked).

Any ideas? 🤔

[danielroe]

For type testing, it's sufficient to have a file in which the utility is used - and then run a typechecking step. The file doesn't need to be run. See https://vitest.dev/guide/testing-types.html for more info.

[michealroberts]

For type testing, it's sufficient to have a file in which the utility is used - and then run a typechecking step. The file doesn't need to be run. See https://vitest.dev/guide/testing-types.html for more info.

Ah yes, quite right, makes sense. I've updated with a few small tests with verify everything is working well.