Google Maps location information sharing page settings button click n… #2634
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-v-in
reviewed
Nov 24, 2024
| @@ -134,7 +135,7 @@ class MainActivity : AppCompatActivity() { | |||
| Log.d(TAG, "Invoked with ${intent.action} and extras $extras") | |||
| super.onCreate(savedInstanceState) | |||
|
|
|||
| val screenId = intent?.getIntExtra(EXTRA_SCREEN_ID, -1).takeIf { it != -1 } ?: ACTION_TO_SCREEN_ID[intent.action] ?: 1 | |||
| val screenId = ACTION_TO_SCREEN_ID[intent.action] ?: intent?.getIntExtra(EXTRA_SCREEN_ID, -1).takeIf { it != -1 } ?: 1 | |||
There was a problem hiding this comment.
What is the screen id sent by Google Maps? Giving priority to the action-based screen id will mean that we might not show the appropriate screen in some cases, so maybe there's a better way to handle this.
There was a problem hiding this comment.
I don't know if 0 is a valid screen id but in case it isn't valid you can also change to:
val screenId = intent?.getIntExtra(EXTRA_SCREEN_ID, -1).takeIf { it > 1 } ?: ACTION_TO_SCREEN_ID[intent.action] ?: 1
So if the screen id is -1, 0, 1 it prefer action otherwise it use the screen id.
I haven't tried, just an idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Maps location information sharing page settings button click no response
app name:google maps
packagename:com.google.android.apps.maps
Steps to reproduce：