Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About 2lcs #86

Merged
merged 2 commits into from
Sep 7, 2023
Merged

About 2lcs #86

merged 2 commits into from
Sep 7, 2023

Conversation

FH-Inway
Copy link
Collaborator

@FH-Inway FH-Inway commented Sep 2, 2023

Adds an update dialog with version information and a GitHub link.

Updates the DocX dependency to version 2.5.0.

@FH-Inway FH-Inway added the dependencies Pull requests that update a dependency file label Sep 2, 2023
@FH-Inway FH-Inway self-assigned this Sep 2, 2023
@fraga
Copy link
Contributor

fraga commented Sep 7, 2023

this is looking good @FH-Inway I guess you can merge. Looks like @TomekMelissa is not active on this repo anymore.

I would just change the version to match the version we are going to release 0.45?

image

@FH-Inway FH-Inway merged commit d7052a6 into microsoft:master Sep 7, 2023
2 checks passed
@FH-Inway
Copy link
Collaborator Author

FH-Inway commented Sep 7, 2023

@fraga Thanks for taking a look. The version displayed is actually taken from the version information of the dll file, so it will dynamically update. Take a look at https://github.com/microsoft/2LCS/releases/tag/v.0.45.0

@fraga
Copy link
Contributor

fraga commented Sep 7, 2023

Beautiful! Good stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants