Skip to content

Commit

Permalink
Enable Git submodule support (#1287)
Browse files Browse the repository at this point in the history
I use git submodule instead of putting the extension source codes
directly in the repo, to my surprise it doesn't automatically initialize
the submodule thus failing the automatic build.

These changes should make the workflow is able to initialize any git
submodules inside the repo thus making the automatic build passes.

Tested in this repo
https://github.com/dibyanugraha/d365-bc-toastui-calendar-control-addin-cicd
  • Loading branch information
dibyanugraha authored Nov 1, 2024
1 parent ec2fae9 commit e0dbcd4
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 0 deletions.
4 changes: 4 additions & 0 deletions RELEASENOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ Page Scripting tests are now supported as part of CI/CD. By specifying pageScrip
- `PageScriptingTestResults` is a JUnit test results file with all results combined.
- `PageScriptingTestResultDetails` are the detailed test results (including videos) when any of the page scripting tests have failures. If the page scripting tests succeed - the details are not published.

### Support for Git submodule

[Git submodule](https://git-scm.com/book/en/v2/Git-Tools-Submodules) is now supported as part of CI/CD on your project.

## v6.0

### Issues
Expand Down
1 change: 1 addition & 0 deletions Templates/AppSource App/.github/workflows/CICD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
1 change: 1 addition & 0 deletions Templates/AppSource App/.github/workflows/Current.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
1 change: 1 addition & 0 deletions Templates/AppSource App/.github/workflows/NextMajor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
1 change: 1 addition & 0 deletions Templates/AppSource App/.github/workflows/NextMinor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ jobs:
with:
ref: ${{ inputs.checkoutRef }}
lfs: true
submodules: recursive

- name: Read settings
uses: microsoft/AL-Go-Actions/ReadSettings@main
Expand Down
1 change: 1 addition & 0 deletions Templates/Per Tenant Extension/.github/workflows/CICD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
lfs: true
submodules: recursive

- name: Initialize the workflow
id: init
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ jobs:
with:
ref: ${{ inputs.checkoutRef }}
lfs: true
submodules: recursive

- name: Read settings
uses: microsoft/AL-Go-Actions/ReadSettings@main
Expand Down

0 comments on commit e0dbcd4

Please sign in to comment.