Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies #1225

Merged
merged 33 commits into from
Oct 29, 2024
Merged

Install dependencies #1225

merged 33 commits into from
Oct 29, 2024

Conversation

freddydk
Copy link
Contributor

@freddydk freddydk commented Sep 27, 2024

Fixes #1215

Add new DeployTo setting called DependencyInstallMode, which can be ignore, install or upgrade. Default is install (which doesn't cause disruption with prior functionality)

If DependencyInstallMode is set to ignore - then dependencies will not be installed/upgraded.

All AppSource Apps will be installed/upgraded first, which can be done in any order as they are installed/upgraded with -installOrUpdateNeededDependencies. All dependency PTEs are installed afterwards in dependency order.

Rules for deploying dependencies to online environments goes here:

If the App (from dependencies) is a PTE:

  • If it is installed in a newer version - leave it and see if it works
  • If it is installed in an older version - Upgrade if DependencyInstallMode is upgrade (else issue WARNING)

If the App (from dependencies) is an AppSource App:

  • If it isn't already installed - install it from AppSource
  • If it is installed in an older version in the Dev scope - issue a warning and leave as is
  • If it is installed in an older version - Upgrade if DependencyInstallMode is upgrade (else issue WARNING)
  • If it is installed in a newer version - issue a warning and leave as is

TODO:

  • Add Release note
  • Add to settings.md

Actions/Deploy/Deploy.ps1 Fixed Show fixed Hide fixed
Actions/Deploy/Deploy.ps1 Fixed Show fixed Hide fixed
Actions/Deploy/Deploy.ps1 Fixed Show fixed Hide fixed
@freddydk freddydk marked this pull request as ready for review September 27, 2024 10:17
@freddydk freddydk requested a review from a team as a code owner September 27, 2024 10:17
Actions/AL-Go-Helper.ps1 Outdated Show resolved Hide resolved
mazhelez
mazhelez previously approved these changes Sep 27, 2024
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Actions/Deploy/Deploy.ps1 Outdated Show resolved Hide resolved
aholstrup1
aholstrup1 previously approved these changes Sep 30, 2024
Actions/Deploy/Deploy.ps1 Outdated Show resolved Hide resolved
Actions/Deploy/Deploy.ps1 Outdated Show resolved Hide resolved
tomasmsft
tomasmsft previously approved these changes Oct 28, 2024
Actions/Deploy/Deploy.ps1 Outdated Show resolved Hide resolved
Actions/Deploy/Deploy.ps1 Outdated Show resolved Hide resolved
@freddydk freddydk enabled auto-merge (squash) October 29, 2024 07:37
@freddydk freddydk merged commit a46044f into microsoft:main Oct 29, 2024
5 checks passed
@freddydk freddydk deleted the issue1215 branch October 29, 2024 11:25
@freddydk freddydk restored the issue1215 branch October 29, 2024 11:25
@freddydk freddydk deleted the issue1215 branch November 1, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: How to add app during deployment from the appDependencyProbingPaths
5 participants