Skip to content
Redfield Validation

Fix ITelemetryModule singleton registration to support presence of keyed services #1034

Sign in to view logs

Fix ITelemetryModule singleton registration to support presence of keyed services

Fix ITelemetryModule singleton registration to support presence of keyed services #1034

Triggered via pull request October 22, 2024 21:23
@CodeBlanchCodeBlanch
synchronize #2908
blanch/keyedservice-fix
Status Success
Total duration 13m 53s
Artifacts –

redfield-sanity-check.yml

on: pull_request
Matrix: build-test-REDFIELD
Fit to window
Zoom out
Zoom in

Annotations

40 warnings
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Endpoints/EndpointMetaAttribute.cs#L10
Avoid unsealed attributes (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1813)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L284
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L313
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/BroadcastProcessor.cs#L35
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/BroadcastProcessor.cs#L26
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/PerformanceCounterTelemetry.cs#L180
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Authentication/ReflectionCredentialEnvelope.cs#L121
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Authentication/ReflectionCredentialEnvelope.cs#L128
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Authentication/ReflectionCredentialEnvelope.cs#L132
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net8.0): BASE/src/Microsoft.ApplicationInsights/Metrics/Implementation/AutocollectedMetricsExtraction/TraceMetricsExtractor.cs#L94
Change type of variable 'dimensionNames' from 'System.Collections.Generic.IList<string>' to 'System.Collections.Generic.List<string>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Endpoints/EndpointMetaAttribute.cs#L10
Avoid unsealed attributes (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1813)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L284
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L313
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/BroadcastProcessor.cs#L35
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/BroadcastProcessor.cs#L26
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/PerformanceCounterTelemetry.cs#L180
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Authentication/ReflectionCredentialEnvelope.cs#L121
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Authentication/ReflectionCredentialEnvelope.cs#L128
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Authentication/ReflectionCredentialEnvelope.cs#L132
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net7.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs#L125
'active == null' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Endpoints/EndpointMetaAttribute.cs#L10
Avoid unsealed attributes (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1813)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L313
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs#L284
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/DataContracts/PerformanceCounterTelemetry.cs#L180
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L54
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L172
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L390
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L489
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L492
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, netcoreapp3.1): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L503
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Endpoints/EndpointMetaAttribute.cs#L10
Avoid unsealed attributes (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1813)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/BroadcastProcessor.cs#L26
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/BroadcastProcessor.cs#L35
Possible multiple enumerations of 'IEnumerable' collection. Consider using an implementation that avoids multiple enumerations. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1851)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/PerformanceCounterTelemetry.cs#L180
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs#L125
'active == null' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L54
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L172
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1854)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L390
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L489
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
build-test-REDFIELD (ubuntu-latest, net6.0): BASE/src/Microsoft.ApplicationInsights/DataContracts/ExceptionTelemetry.cs#L492
Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)