-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to read diagnostics config from the path defined in environment variable #2769
Conversation
...s/Extensibility/Implementation/Tracing/SelfDiagnostics/SelfDiagnosticsConfigRefresherTest.cs
Outdated
Show resolved
Hide resolved
...Insights/Extensibility/Implementation/Tracing/SelfDiagnostics/SelfDiagnosticsConfigParser.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
configFilePath = Path.Combine(logDiagnosticsPath, ConfigFileName); | ||
logDirectory = logDiagnosticsPath; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the blank space before else if
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to have a blank line before comment?
...Insights/Extensibility/Implementation/Tracing/SelfDiagnostics/SelfDiagnosticsConfigParser.cs
Outdated
Show resolved
Hide resolved
...s/Extensibility/Implementation/Tracing/SelfDiagnostics/SelfDiagnosticsConfigRefresherTest.cs
Outdated
Show resolved
Hide resolved
...s/Extensibility/Implementation/Tracing/SelfDiagnostics/SelfDiagnosticsConfigRefresherTest.cs
Outdated
Show resolved
Hide resolved
…tionInsights.Tests/Extensibility/Implementation/Tracing/SelfDiagnostics/SelfDiagnosticsConfigRefresherTest.cs Co-authored-by: Reiley Yang <reyang@microsoft.com>
Bit confused with this description. |
@cijothomas : See: Line 50 in 6525f04
|
@Yun-Ting please add an entry in the changelog. |
Fix Issue #2724.
Changes
Design assumption:
Function Apps environment will set the value of this environment variable: APPLICATIONINSIGHTS_LOG_DIAGNOSTICS to be a directory that
at host initialization.
The SDK reads the value of APPLICATIONINSIGHTS_LOG_DIAGNOSTICS, and parse settings of
ApplicationInsightsDiagnostics.json
file and write diagnostics log to the directory.Checklist
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors: