-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DotNet] Add details to README in certificate samples #3995
base: main
Are you sure you want to change the base?
Conversation
Update README.md
@JhontSouth For SN+I, I believe we can leave out the steps for creating a certifcate outside KeyVault. The reason being is that for MS folks, the cert needs to be from OneCert. In fact, creating a self-signed cert in KeyVault for SN+I just won't work. I will update the README once I have all the details. Basically they have to onboard with OneCert, and then they can create SN+I compatible certificates. Also, for SN+I, they can't upload the cert to the App Registration (I didn't notice if the READ still indicated that). It will cause a different alert if they do (pinning certs is not allowed either). |
# Conflicts: # samples/csharp_dotnetcore/84.bot-authentication-certificate/AuthCertificateBot.csproj # samples/csharp_dotnetcore/84.bot-authentication-certificate/README.md # samples/csharp_dotnetcore/85.bot-authentication-sni/README.md
Hi @tracyboehrer, we had this feedback pending. We changed the README's instructions to specify that the sample requires an existing certificate obtained through OneCert. We also removed the steps to upload the certificate to the app registration and replaced them with the manifest configuration, which is used for SN+I. |
#minor
Description
This PR adds more information to the README certificate samples to have an easier complete guide for SSL/TLS certificate configuration.
Proposed Changes