-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default target framework to netstandard2.1 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zijchen
commented
Feb 9, 2024
- Default to netstandard2.1 instead of the net46 from SqlTasks.target, also allows it to be overridable with anything like net6.0 or net8.0 - fixes SQLProj Targets Wrong Framework Despite Explicit net6.0 Specification #330
- Import Microsoft.NET.Sdk.targets which adds more features as supported by .NET such as transitive project dependencies - fixes SDK based project does not cover the transitive dependencies on the project reference #278
…into zijchen/netstandard
What will our story be for .net framework? |
Since sqlproj doesn't really care about .NET version, you can set the target framework to net46 if you want. The test confirms that. If you're asking about using the .NET Framework version of msbuild, nothing is changed in that path since we need the targets from the .NET SDK. |
zijchen
requested review from
dzsquared,
llali,
chlafreniere,
ssreerama,
namangupta211 and
SeenaAugusty
February 13, 2024 23:12
SeenaAugusty
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.