Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Microsoft.Build.Sql for utilising in Visual Studio #443

Merged
merged 12 commits into from
May 31, 2024

Conversation

Ri7Sh
Copy link
Contributor

@Ri7Sh Ri7Sh commented May 14, 2024

No description provided.

src/Microsoft.Build.Sql/sdk/Sdk.targets Outdated Show resolved Hide resolved
src/Microsoft.Build.Sql/sdk/Sdk.props Outdated Show resolved Hide resolved
src/Microsoft.Build.Sql/sdk/Sdk.props Outdated Show resolved Hide resolved
@Ri7Sh Ri7Sh requested review from zijchen and ErikEJ May 17, 2024 09:38
Copy link
Contributor

@ErikEJ ErikEJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ri7Sh Ri7Sh requested a review from dzsquared May 17, 2024 10:48
@zijchen zijchen requested a review from chlafreniere May 17, 2024 17:34
@zijchen zijchen mentioned this pull request May 22, 2024
@Ri7Sh Ri7Sh merged commit 3cd56f7 into main May 31, 2024
13 checks passed
@Ri7Sh Ri7Sh deleted the sharmari/ssdtsdk branch May 31, 2024 18:23
@czb182
Copy link

czb182 commented Jun 7, 2024

Should the latest version of VS be able to build this now, using latest 1.19-preview sdk?

I tried migrating one, but gives build error around .net framework. I followed the migration docs.

Your project does not reference ".NETFramework,Version=v4.7.2" framework. Add a reference to ".NETFramework,Version=v4.7.2" in the "TargetFrameworks" property of your project file and then re-run NuGet restore. Deloitte.Omnia.Materiality.Database C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\NuGet\17.0\Microsoft.NuGet.targets 198

@dzsquared
Copy link
Contributor

@czb182 unfortunately more than this PR is needed for support in Visual Studio. this work is ongoing!
you can track progress for SSDT on #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants