Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VS targets path and Excluding BuildExtensionConfiguration and DeployExtensionConfiguration from Build #463

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Adding VS targets path and Excluding BuildExtensionConfiguration and DeployExtensionConfiguration from Build #463

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4996f1
Importing ssdt targets if in VS
Ri7Sh Jun 7, 2024
93f02c6
Updating Sdk.targets to bring support for BuildExtensionConfiguration…
Ri7Sh Jun 28, 2024
991f769
Correcting BuildAction Name
Ri7Sh Jul 4, 2024
8a2ee98
Adding Tests for BuildExtensionConfiguration, DeploymentExtensionConf…
Ri7Sh Jul 8, 2024
643779e
Adding TestData
Ri7Sh Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Microsoft.Build.Sql/sdk/Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@
<Import Condition="'$(NetCoreBuild)' == 'true'" Project="$(MSBuildSdksPath)/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets" />
<Import Condition="'$(NetCoreBuild)' == 'true'" Project="$(MSBuildSdksPath)/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets" />

<Import Condition="'$(NetCoreBuild)' != 'true' AND Exists('$(MSBuildExtensionsPath)\Sdks\Microsoft.SqlProject.Sdk\ssdtprojectsystem.targets')"
Project="$(MSBuildExtensionsPath)\Sdks\Microsoft.SqlProject.Sdk\ssdtprojectsystem.targets" />

<!-- Add dacpac file BuiltProjectOutputGroupOutput, so that it will get included in the NuGet package by the Pack target -->
<Target Name="AddDacpacToBuiltProjectOutputGroupOutput" BeforeTargets="BuiltProjectOutputGroup">
<ItemGroup>
Expand All @@ -70,6 +73,8 @@
<Build Remove="@(PreDeploy)" />
<Build Remove="@(PostDeploy)" />
<Build Remove="@(None)" />
<Build Remove="@(BuildExtensionConfiguration)" />
Ri7Sh marked this conversation as resolved.
Show resolved Hide resolved
<Build Remove="@(DeployExtensionConfiguration)" />
</ItemGroup>

<!-- Target to resolve package references into database references to the underlying DACPACs inside the packages -->
Expand Down