Fix Type Name Inconsistency & Typo in cpu_adam #6732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
approved these changes
Nov 8, 2024
loadams
requested review from
hwchen2017,
tjruwase and
tohtana
and removed request for
awan-10
hwchen2017
approved these changes
Nov 8, 2024
tjruwase
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typing error & inconsistency in cpu-adam code, while not affecting functionality, impacts code readability. Specifically, the type name
ds_params_percision_tcontains a typo ('percision'), whereas the related type nameds_state_precision_tis spelled correctly. I think it is beneficial to fix this typo&inconsistency to improve code readability, maintainability and further development.I have tested the corrected version of cpu_adam, and it compiles and runs successfully.
Compilation Log:
