Prototype putting blobs in summary #21701
Conversation
github-actions
bot
added
area: contributor experience
area: driver
| @@ -728,6 +730,20 @@ export class BlobManager extends TypedEventEmitter<IBlobManagerEvents> { | |||
| ), | |||
| ); | |||
| } | |||
| if (this.redirectTable.size > 0) { | |||
| const redirectTree = new SummaryTreeBuilder(blobsTreeName); | |||
There was a problem hiding this comment.
this is the core of the change, just trying to move the redirect table from an opaque blob (above) to a summary tree. this keeps the blobs as attachment blobs. A change like this required changes to all layers, so very costly to rollout.
You can imagine also adding the ability to specify regular blob entries in this tree which have content, which could replace the detached case, but we'd need to keep attachment blobs for the attached case, since we upload them independently of summaries.
We could change blob upload to be a summary itself, that just incrementally adds a single blob, but that would also introduce concurrency issues between clients uploading blobs, and the summarizer due to the parent summary handle changing for every upload. to solve this, we'd likely need to send an op, which should work, and could be better than the current blob op, in that the server wouldn't need to read it, as every blob is already summarized at upload. However, there are problem where summarizer can never succeed if blobs keep getting uploaded, this is harder to solve without trade offs.
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
in progress