[release/2.3] Update blob upload to use managed identity #22674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Updates usages of `az storage` to leverage login information for the service principal that our pipelines assume. A successful test run for api report upload can be found [here](https://dev.azure.com/fluidframework/internal/_build/results?buildId=296024&view=logs&j=897f79ef-2c90-5d46-29c0-b0ed22a2d39c&t=9305981a-7602-52ec-3c74-5436202de3b9) (requires internal project access). [This run](https://dev.azure.com/fluidframework/internal/_build/results?buildId=296015&view=logs&j=897f79ef-2c90-5d46-29c0-b0ed22a2d39c&t=9305981a-7602-52ec-3c74-5436202de3b9) used the same code but was triggered before I gave the service principal associated with our service connection storage blob contributor permissions. The fact that this failed gives a bit more confidence that this change is working as intended. [This run](https://dev.azure.com/fluidframework/internal/_build/results?buildId=296052&view=logs&j=c719ff29-64ed-5818-044d-14407c6a65d1&t=660fdca3-7237-5adb-817c-3d74f278c44a) verifies dev releases upload as expected. --------- Co-authored-by: Abram Sanderson <absander@microsoft.com>
github-actions
bot
added
base: release
|
Warning WARNING: This PR is targeting a release branch! All changes must first be merged into Changes to release branches require approval from the Patch Triage group before merging. For more details, see our internal documentation for the patch policy and processes for |
sonalideshpandemsft
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the blob upload steps to use the pipeline's identity as authentication rather than a storage key.
Cherry-pick of #22647