Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@fluid-example/ai-collab): Integrate User Avatar into Sample App #22850

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

chentong7
Copy link
Contributor

@chentong7 chentong7 commented Oct 18, 2024

Description

This PoC demonstrates the integration of Microsoft's Presence API into an existing AI-powered application. The key objectives include ramping up the current AI app, incorporating the Presence API library, and integrating this functionality to display user presence information. Specifically, this demo will show the avatar of a signed-in Microsoft account on top of the sample AI app's user interface, indicating the user’s online status or availability in real time.

By completing this PoC, we aim to enhance the AI app's user experience with seamless integration of Microsoft's identity and presence services, allowing for personalized interactions based on user status.

Sample

Recording.2024-11-25.135720.mp4

@github-actions github-actions bot added area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Oct 18, 2024
examples/apps/ai-collab/package.json Outdated Show resolved Hide resolved
examples/apps/ai-collab/package.json Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/app/tasks-list/presence.ts Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/app/tasks-list/page.tsx Outdated Show resolved Hide resolved
@chentong7 chentong7 force-pushed the ai-tong branch 2 times, most recently from df778fe to 8a65277 Compare October 22, 2024 23:10
@chentong7 chentong7 requested review from alexvy86 and a team October 22, 2024 23:11
@chentong7 chentong7 changed the title AI App Ramp up + Presence Integration feat(@fluid-example/ai-collab): Integrate User Avatar into Sample App Oct 23, 2024
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

No packages impacted by the change.


Baseline commit: 651a64c
Baseline build: 309862
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 23, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.08 KB 467.11 KB +35 Bytes
azureClient.js 563.85 KB 563.9 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.27 KB 263.29 KB +14 Bytes
fluidFramework.js 428.71 KB 428.73 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 530.45 KB 530.5 KB +49 Bytes
odspDriver.js 98.65 KB 98.67 KB +21 Bytes
odspPrefetchSnapshot.js 43.04 KB 43.05 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 419.17 KB 419.18 KB +7 Bytes
Total Size 3.38 MB 3.38 MB +245 Bytes

Baseline commit: 651a64c

Generated by 🚫 dangerJS against 805660e

@chentong7 chentong7 requested review from seanimam, alexvy86 and a team October 24, 2024 18:09
@chentong7 chentong7 requested a review from tylerbutler October 24, 2024 22:39
@chentong7 chentong7 force-pushed the ai-tong branch 2 times, most recently from 0664756 to c809a4f Compare October 25, 2024 20:12
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having trouble understanding what the presence code is doing. I tried running the sample locally with tinylicious and I don't see any presence information. Am I doing something wrong?

@chentong7 chentong7 force-pushed the ai-tong branch 2 times, most recently from b0931d8 to 84daca0 Compare November 25, 2024 22:14
@alexvy86
Copy link
Contributor

Something's still weird... in the recording the first tab is staying at 1 bubble after the other two have been added. I see something similar, sometimes in the second tab as well:

image

@chentong7
Copy link
Contributor Author

chentong7 commented Dec 18, 2024

Latest version works fine. Thank you all!!!

Recording.2024-12-17.173044.mp4

Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last small things but lgtm otherwise.

examples/apps/ai-collab/src/app/presence.ts Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/app/presence.ts Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/app/presence.ts Outdated Show resolved Hide resolved
chentong7 and others added 4 commits January 6, 2025 11:03
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170492 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors


Copy link
Contributor

github-actions bot commented Jan 6, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170492 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors


@chentong7 chentong7 merged commit 915b76b into microsoft:main Jan 6, 2025
32 checks passed
@chentong7 chentong7 deleted the ai-tong branch January 6, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Changes that focus on our examples base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants