-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build-infrastructure): Add selection and filtering APIs #22866
Open
tylerbutler
wants to merge
49
commits into
microsoft:main
Choose a base branch
from
tylerbutler:bt-build-infra-filter-03
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,160
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
Build related issues
public api change
Changes to a public API
base: main
PRs targeted against main branch
labels
Oct 22, 2024
This was referenced Oct 22, 2024
tylerbutler
force-pushed
the
bt-build-infra-filter-03
branch
from
October 22, 2024 16:29
42bf221
to
2edda8d
Compare
msfluid-bot
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 5c17a9c |
tylerbutler
force-pushed
the
bt-build-infra-filter-03
branch
from
October 22, 2024 17:25
2edda8d
to
604ac31
Compare
tylerbutler
force-pushed
the
bt-build-infra-filter-03
branch
from
October 23, 2024 00:13
604ac31
to
df01369
Compare
…est.ts Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
…est.ts Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
tylerbutler
force-pushed
the
bt-build-infra-filter-03
branch
from
October 24, 2024 17:56
9303cff
to
50e1cb9
Compare
tylerbutler
force-pushed
the
bt-build-infra-filter-03
branch
from
October 25, 2024 01:28
50e1cb9
to
e8a8af9
Compare
tylerbutler
force-pushed
the
bt-build-infra-filter-03
branch
from
October 28, 2024 16:57
e8a8af9
to
0203208
Compare
tylerbutler
commented
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: build
Build related issues
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is one of several and builds on previous PRs. Please see previous PRs for more background.
This change adds selection and filtering logic to the build-infrastructure package. Much of this code currently exists in build-cli, but the implementation has changed slightly to accommodate the new interfaces. There are also new git-related APIs, which are used in the "changed since" selection/filter logic.
None of the code is shared with existing implementation in build-cli. Once build-infrastructure is ready, the build-cli functionality will be replaced with the build-infra stuff.