Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-infrastructure): Add selection and filtering APIs #22866

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Oct 22, 2024

Note

This PR is one of several and builds on previous PRs. Please see previous PRs for more background.

This change adds selection and filtering logic to the build-infrastructure package. Much of this code currently exists in build-cli, but the implementation has changed slightly to accommodate the new interfaces. There are also new git-related APIs, which are used in the "changed since" selection/filter logic.

None of the code is shared with existing implementation in build-cli. Once build-infrastructure is ready, the build-cli functionality will be replaced with the build-infra stuff.

Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

No packages impacted by the change.


Baseline commit: 5c17a9c
Baseline build: 301786
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 22, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.85 KB 459.89 KB +35 Bytes
azureClient.js 557 KB 557.04 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.47 KB 259.48 KB +14 Bytes
fluidFramework.js 405.81 KB 405.82 KB +14 Bytes
loader.js 134.16 KB 134.18 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.29 KB 148.29 KB +7 Bytes
odspClient.js 523.96 KB 524 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.48 KB 164.49 KB +7 Bytes
sharedTree.js 396.27 KB 396.28 KB +7 Bytes
Total Size 3.31 MB 3.31 MB +245 Bytes

Baseline commit: 5c17a9c

Generated by 🚫 dangerJS against 604ac31

tylerbutler and others added 5 commits October 24, 2024 10:25
…est.ts

Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
…est.ts

Co-authored-by: Alex Villarreal <716334+alexvy86@users.noreply.github.com>
@tylerbutler tylerbutler marked this pull request as ready for review October 29, 2024 01:18
@tylerbutler tylerbutler requested review from zhenmichael and a team October 29, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants