Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(client): Update build-tools to latest release 0.50.0 #22974

Merged

Conversation

tylerbutler
Copy link
Member

Updated the following:

client (release group)

Dependencies on build-tools updated:

@fluid-tools/build-cli: 0.50.0
@fluidframework/build-tools: 0.50.0
@fluidframework/bundle-size-tools: 0.50.0
@fluid-tools/version-tools: 0.50.0

…e group

Updated the following:

  client (release group)
  client-release-group-root

Dependencies on build-tools updated:

  @fluid-tools/build-cli: 0.50.0
  @fluidframework/build-tools: 0.50.0
  @fluidframework/bundle-size-tools: 0.50.0
  @fluid-tools/version-tools: 0.50.0
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dds: tree area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Nov 4, 2024
@tylerbutler tylerbutler requested a review from a team November 5, 2024 00:11
Copy link
Collaborator

@msfluid-bot msfluid-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage Summary

No packages impacted by the change.


Baseline commit: 2ccf16a
Baseline build: 304226
Happy Coding!!

Code coverage comparison check passed!!

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 5, 2024

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 464.21 KB 464.24 KB +35 Bytes
azureClient.js 562.45 KB 562.5 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 261.86 KB 261.87 KB +14 Bytes
fluidFramework.js 424.73 KB 424.75 KB +14 Bytes
loader.js 134.17 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 148.54 KB 148.55 KB +7 Bytes
odspClient.js 528.3 KB 528.34 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 164.76 KB 164.76 KB +7 Bytes
sharedTree.js 415.19 KB 415.2 KB +7 Bytes
Total Size 3.36 MB 3.36 MB +245 Bytes

Baseline commit: 2ccf16a

Generated by 🚫 dangerJS against 233150e

Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment below, which I think it's just pnpm weirdness. I'm getting tempted to go look at their code to see how they set the dev property.

@@ -28115,7 +28479,6 @@ packages:
/escape-string-regexp@2.0.0:
resolution: {integrity: sha512-UpzcLCXolUWcNu5HtVMHYdXJjArjsF9C0aNnquZYY4uW/Vu0miy5YoWvbV345HauVvcAUnpRuhMMcqTcGOY2+w==}
engines: {node: '>=8'}
dev: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what to make of these dev: true lines disappearing, given we're only changing dev-dependencies in the PR. At this point I suspect some pnpm bug? Still, the fact that they're just disappearing and not changing to dev: false makes me think it's probably ok...? Something like "this is not only a dev dependency (dev: true) nor only a prod dependency (dev: false), but transitive through both kinds"? Which still doesn't explain how this PR could cause that kind of change, but oh well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given we're only changing dev-dependencies in the PR.

Not quite true unfortunately; local-server-tests have a prod dep on build-tools. I don't know if it's needed, but it's there. Found it using this command:

pnpm -r exec -- npm pkg get name dependencies.@fluidframework/build-tools

And indeed, running pnpm why escape-string-regexp@2.0.0 in the packages/test/local-server-tests folder yields:

dependencies:
@fluidframework/build-tools 0.50.0
└─┬ @fluid-tools/version-tools 0.50.0
  └─┬ @oclif/plugin-commands 4.1.7
    └─┬ @oclif/table 0.3.3
      └─┬ ink 5.0.1
        └─┬ stack-utils 2.0.6
          └── escape-string-regexp 2.0.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, the change at least makes more sense now. I suspect that should be a dev-dep, I'll look into it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR here ready once this merges: #22982.

@tylerbutler tylerbutler enabled auto-merge (squash) November 5, 2024 19:18
@tylerbutler tylerbutler merged commit 0b57176 into microsoft:main Nov 5, 2024
33 checks passed
@tylerbutler tylerbutler deleted the bump_deps_build-tools_minor_client branch November 5, 2024 19:56
Josmithr pushed a commit that referenced this pull request Nov 5, 2024
Updated the following:

  client (release group)

Dependencies on build-tools updated:

  @fluid-tools/build-cli: 0.50.0
  @fluidframework/build-tools: 0.50.0
  @fluidframework/bundle-size-tools: 0.50.0
  @fluid-tools/version-tools: 0.50.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants