-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(client): Update build-tools to latest release 0.50.0 #22974
build(client): Update build-tools to latest release 0.50.0 #22974
Conversation
…e group Updated the following: client (release group) client-release-group-root Dependencies on build-tools updated: @fluid-tools/build-cli: 0.50.0 @fluidframework/build-tools: 0.50.0 @fluidframework/bundle-size-tools: 0.50.0 @fluid-tools/version-tools: 0.50.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 2ccf16a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comment below, which I think it's just pnpm weirdness. I'm getting tempted to go look at their code to see how they set the dev
property.
@@ -28115,7 +28479,6 @@ packages: | |||
/escape-string-regexp@2.0.0: | |||
resolution: {integrity: sha512-UpzcLCXolUWcNu5HtVMHYdXJjArjsF9C0aNnquZYY4uW/Vu0miy5YoWvbV345HauVvcAUnpRuhMMcqTcGOY2+w==} | |||
engines: {node: '>=8'} | |||
dev: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what to make of these dev: true
lines disappearing, given we're only changing dev-dependencies in the PR. At this point I suspect some pnpm bug? Still, the fact that they're just disappearing and not changing to dev: false
makes me think it's probably ok...? Something like "this is not only a dev dependency (dev: true
) nor only a prod dependency (dev: false
), but transitive through both kinds"? Which still doesn't explain how this PR could cause that kind of change, but oh well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given we're only changing dev-dependencies in the PR.
Not quite true unfortunately; local-server-tests have a prod dep on build-tools. I don't know if it's needed, but it's there. Found it using this command:
pnpm -r exec -- npm pkg get name dependencies.@fluidframework/build-tools
And indeed, running pnpm why escape-string-regexp@2.0.0
in the packages/test/local-server-tests folder yields:
dependencies:
@fluidframework/build-tools 0.50.0
└─┬ @fluid-tools/version-tools 0.50.0
└─┬ @oclif/plugin-commands 4.1.7
└─┬ @oclif/table 0.3.3
└─┬ ink 5.0.1
└─┬ stack-utils 2.0.6
└── escape-string-regexp 2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, the change at least makes more sense now. I suspect that should be a dev-dep, I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a PR here ready once this merges: #22982.
Updated the following: client (release group) Dependencies on build-tools updated: @fluid-tools/build-cli: 0.50.0 @fluidframework/build-tools: 0.50.0 @fluidframework/bundle-size-tools: 0.50.0 @fluid-tools/version-tools: 0.50.0
Updated the following:
client (release group)
Dependencies on build-tools updated:
@fluid-tools/build-cli: 0.50.0
@fluidframework/build-tools: 0.50.0
@fluidframework/bundle-size-tools: 0.50.0
@fluid-tools/version-tools: 0.50.0