Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(local-server-tests): Clean-up dependencies #22984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(local-server-tests): Clean-up dependencies #22984

wants to merge 2 commits into from
+198 −95

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Nov 5, 2024

Description

This is a private package that only runs some tests. It has no need of production dependencies, so this PR does two things:

  • Move all its dependencies to devDependencies
  • Removes several dependencies that were not used

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: main PRs targeted against main branch labels Nov 5, 2024
@alexvy86 alexvy86 mentioned this pull request Nov 5, 2024
Closed
@alexvy86 alexvy86 enabled auto-merge (squash) November 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

Assignees
No one assigned
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvy86 @tylerbutler