-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(build-tools): base command with build project context #23257
base: main
Are you sure you want to change the base?
Conversation
build-tools/packages/build-cli/src/library/commands/baseCommand.ts
Outdated
Show resolved
Hide resolved
@@ -1,7 +1,6 @@ | |||
{ | |||
"name": "@fluid-tools/build-infrastructure", | |||
"version": "0.52.0", | |||
"private": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about the motivation or use case for the whole change, if it requires us to make this public and get it published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question. The ultimate goal is to replace all of the release group/package handling code in build-cli commands with the new code from build-infra. But rolling out changes to all the commands at once is just too big a change/task, so the plan is to convert commands one-by-one by creating new versions of the commands that use this new base class. That way we can roll out the changes piecemeal.
Long-term, we may not need a separate package for the infra stuff, but at the moment it's much easier for it to be separate right now, because build-cli and fluid-build need the underlying code. Unfortunately, fluid-build cannot depend on build-cli today because there's already a dep going the other way (that is, build-cli depends on fluid-build).
BaseCommandWithBuildProject class inherits existing BaseCommand class. Provides alternative to existing Context class which uses BuildProject from the build-infrastructure package instead.
This new base command is to be used to re-implement existing commands.