Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(build-tools): base command with build project context #23257

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

zhenmichael
Copy link
Contributor

BaseCommandWithBuildProject class inherits existing BaseCommand class. Provides alternative to existing Context class which uses BuildProject from the build-infrastructure package instead.

This new base command is to be used to re-implement existing commands.

@zhenmichael zhenmichael requested review from Copilot and alexvy86 and removed request for Copilot December 5, 2024 18:02
@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Dec 5, 2024
@@ -1,7 +1,6 @@
{
"name": "@fluid-tools/build-infrastructure",
"version": "0.52.0",
"private": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about the motivation or use case for the whole change, if it requires us to make this public and get it published.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question. The ultimate goal is to replace all of the release group/package handling code in build-cli commands with the new code from build-infra. But rolling out changes to all the commands at once is just too big a change/task, so the plan is to convert commands one-by-one by creating new versions of the commands that use this new base class. That way we can roll out the changes piecemeal.

Long-term, we may not need a separate package for the infra stuff, but at the moment it's much easier for it to be separate right now, because build-cli and fluid-build need the underlying code. Unfortunately, fluid-build cannot depend on build-cli today because there's already a dep going the other way (that is, build-cli depends on fluid-build).

@tylerbutler tylerbutler self-requested a review December 9, 2024 19:03
@github-actions github-actions bot added the public api change Changes to a public API label Dec 16, 2024
@zhenmichael zhenmichael requested a review from a team as a code owner December 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants