Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire ai task planner example to explicit #23258

Merged
merged 14 commits into from
Dec 11, 2024
Merged

Wire ai task planner example to explicit #23258

merged 14 commits into from
Dec 11, 2024

Conversation

seanimam
Copy link
Contributor

@seanimam seanimam commented Dec 5, 2024

Description

Wire's the ai task planner example to the new ai-collab api surface which also uses the explicit strategy under the hood instead of the implicit strategy.

@seanimam seanimam requested a review from a team December 5, 2024 19:04
@github-actions github-actions bot added base: main PRs targeted against main branch area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file labels Dec 5, 2024
alexvy86
alexvy86 reviewed Dec 9, 2024
View reviewed changes
examples/apps/ai-collab/tsconfig.json Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/types/sharedTreeAppSchema.ts Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/types/sharedTreeAppSchema.ts Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/types/sharedTreeAppSchema.ts Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/types/sharedTreeAppSchema.ts Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/components/TaskGroup.tsx Show resolved Hide resolved
examples/apps/ai-collab/src/components/TaskGroup.tsx Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/components/TaskCard.tsx Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/components/TaskCard.tsx Outdated Show resolved Hide resolved
examples/apps/ai-collab/src/components/TaskCard.tsx Outdated Show resolved Hide resolved
alexvy86
alexvy86 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@seanimam seanimam merged commit aed6e3a into microsoft:main Dec 11, 2024
26 checks passed
Josmithr pushed a commit to Josmithr/FluidFramework that referenced this pull request Dec 12, 2024
@seanimam @Josmithr
Wire ai task planner example to explicit (microsoft#23258)
82c414d 
## Description
Wire's the ai task planner example to the new ai-collab api surface
which also uses the explicit strategy under the hood instead of the
implicit strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WayneFerrao WayneFerrao WayneFerrao left review comments

@alexvy86 alexvy86 alexvy86 approved these changes

Assignees
No one assigned
Labels
area: examples Changes that focus on our examples base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanimam @alexvy86 @WayneFerrao