Standardize segment typing based on exposure #23315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
There was a problem hiding this comment.
Copilot reviewed 17 out of 32 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- packages/dds/merge-tree/src/perspective.ts: Evaluated as low risk
- packages/dds/merge-tree/src/sortedSegmentSet.ts: Evaluated as low risk
- packages/dds/merge-tree/src/snapshotlegacy.ts: Evaluated as low risk
- packages/dds/merge-tree/src/snapshotV1.ts: Evaluated as low risk
- packages/dds/merge-tree/src/snapshotLoader.ts: Evaluated as low risk
- packages/dds/merge-tree/src/revertibles.ts: Evaluated as low risk
- packages/dds/merge-tree/src/partialLengths.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/beastTest.spec.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/client.applyMsg.spec.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/client.localReferenceFarm.spec.ts: Evaluated as low risk
- packages/dds/matrix/src/matrix.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/client.localReference.spec.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/client.attributionFarm.spec.ts: Evaluated as low risk
- packages/dds/merge-tree/src/test/client.getPosition.spec.ts: Evaluated as low risk
- packages/dds/merge-tree/src/MergeTreeTextHelper.ts: Evaluated as low risk
anthony-murphy
force-pushed
the
isegment-typing
branch
from
ee88244 to
fc94acc
Compare
anthony-murphy
force-pushed
the
isegment-typing
branch
from
fc94acc to
b10f116
Compare
jzaffiro
approved these changes
Dec 12, 2024
Josmithr
pushed a commit
to Josmithr/FluidFramework
that referenced
this pull request
Dec 12, 2024
I merge tree we have three different layers of segment: 1. ISegment - This is the consumer facing type which is exposed via legacy 2. ISegmentInternal - This type is used internally between fluid framework packages that leverage merge-tree 3. ISegmentLeaf - This type is not exported from the merge-tree package. This change standardizes usage in preparation for the upcoming changes which will move some properties between the layers. Doing this change first will reduce the number of lines modified when changes are made. There are not functional changes in this PR, it is all typing, and there are not changes to any types which are exported to customers, so no type test or api markdowns are impacted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merge tree we have three different layers of segment:
This change standardizes usage in preparation for the upcoming changes which will move some properties between the layers. Doing this change first will reduce the number of lines modified when changes are made.
There are not functional changes in this PR, it is all typing, and there are not changes to any types which are exported to customers, so no type test or api markdowns are impacted