test(client-presence): old collateral connection and stale connection tests

[WillieHabi]

Description

There are 6 tests that are added (and disabled) in this PR.

The first test is to verify that old collateral connections do not effect the connection status of remote attendees. This scenario was written as an edge case to old solution where old connection information sent in a join response would result in the attendee connection status being set to 'Disconnected'.

The next five have to do with stale remote attendee's connection status upon local client reconnect scenarios:

Presence
  PresenceManager
    when connected
      attendee
        that is joining
          - as collateral with old connection info and connected is NOT announced via `attendeeJoined
        that is already known
          and then local client disconnects
            - updates status of attendee with stale connection after 30s delay upon local reconnection
            - does not update status of attendee with stale connection if local client does not reconnect
            - does not update status of attendee with stale connection if local client reconnection lasts less than 30s
            - does not update status of attendee with stale connection if attendee rejoins
            - does not update status of attendee with stale connection if attendee sends datastore update
            - marks attendee with stale connection as active when attendee disconnects after local reconnection
            - updates status of attendee with stale connection only 30s after most recent local reconnection

I added connect() and disconnect() function to MockEphemeralRuntime that manipulates the connection state of the local client.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

packages/framework/presence/src/internalTypes.ts:54

• The event names 'connected' and 'disconnected' should be consistent with the rest of the codebase.

export interface EphemeralRuntimeEvents extends IEvent {

packages/framework/presence/src/test/mockEphemeralRuntime.ts:121

• The removal of the 'on' and 'off' methods from 'MockEphemeralRuntime' might break existing code that relies on these methods. Confirm if this change was intentional and if it might cause any issues.

public clientId: string | undefined;

packages/framework/presence/src/test/mockEphemeralRuntime.ts:71

• [nitpick] Ensure that the new event handling mechanism is consistent with the rest of the codebase and aligns with existing conventions.

extends TypedEventEmitter<EphemeralRuntimeEvents>

[WillieHabi]

Updated the tests a bit from our last discussion, looking for some guidance around better ways to simulate reconnect since I now know we want to move away from TypedEventEmitter @jason-ha

[jason-ha]

I like a lot - still have notes :)

[jason-ha]

few more suggestions

[WillieHabi]

@jason-ha Thanks for approval, but added some stuff from the feedback that definitely requires additional review before merging:

• created a separate describe block 'when local client disconnects' to move away from 'and has their connection removed'.
• created a test case in which a datastore update message activates a stale attendee.
• made larger advances in time (a minute) before checking for connection status of stale attendees

[jason-ha]

"stale" attendee needs a better descriptor or a comment in code. There isn't anything explaining what that is. (How do I check that there is also a test case for a non-stale attendee? What is the difference?)
Please also update the test case list in PR description.

[WillieHabi]

"stale" attendee needs a better descriptor or a comment in code. There isn't anything explaining what that is. (How do I check that there is also a test case for a non-stale attendee? What is the difference?) Please also update the test case list in PR description.

I added a description of the stale connection scenario before the tests.

I also did not like the wording from "stale attendee" to "attendee with stale connection". We're waiting to change the connection status of the attendee, so it feels like that's the actual part getting "stale". Can switch back if the conciseness if preferred.